From c2f2c227a34e6ef958875b090a289015652f6ed4 Mon Sep 17 00:00:00 2001 From: liuzhaokun Date: Wed, 5 Apr 2017 17:03:28 +0800 Subject: [PATCH] [STORM-2454] the default returned value of this method which named isConsumerAutoCommitMode in KafkaSpoutConfig.java should be false --- .../java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java b/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java index 61e102acf32..57a00d3e96f 100644 --- a/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java +++ b/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java @@ -497,7 +497,7 @@ public long getOffsetsCommitPeriodMs() { } public boolean isConsumerAutoCommitMode() { - return kafkaProps.get(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG) == null // default is true + return kafkaProps.get(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG) == null // default is false || Boolean.valueOf((String)kafkaProps.get(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG)); }