Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORM-2492: Adding Cassandra Object Mapper statement builder. #2085

Merged
merged 1 commit into from Aug 20, 2017

Conversation

tandrup
Copy link
Contributor

@tandrup tandrup commented Apr 24, 2017

Allow bolts to emit object annotated with @Table and generate CQL for them automatically using the Cassandra object mapper.

@tandrup
Copy link
Contributor Author

tandrup commented Apr 24, 2017

It fails on

[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project storm: Too many files with unapproved license: 3 See RAT report in: /home/travis/build/apache/storm/target/rat.txt -> [Help 1]

Do I need to do anything with licenses?

@vesense
Copy link
Member

vesense commented Apr 24, 2017

@tandrup Yes, you need to apply apache license to new files.

@tandrup tandrup changed the title Adding Cassandra Object Mapper statement builder. STORM-2492: Adding Cassandra Object Mapper statement builder. Apr 25, 2017
@tandrup
Copy link
Contributor Author

tandrup commented Apr 25, 2017

Thanks for the tip @vesense

@tandrup tandrup force-pushed the cassandra-object-mapper branch 3 times, most recently from 73f4797 to ac38679 Compare May 11, 2017 20:07
@HeartSaVioR
Copy link
Contributor

@tandrup
Sorry to visit this PR really late. We have now introduced checkstyle for the master branch, and build is failing due to the violation. Could you fix it?

@tandrup tandrup force-pushed the cassandra-object-mapper branch 2 times, most recently from ec3da0c to bdb0063 Compare July 22, 2017 05:30
Allow bolts to emit object annotated with `@Table` and generate CQL for them automatically using the Cassandra object mapper.
@tandrup
Copy link
Contributor Author

tandrup commented Jul 22, 2017

@HeartSaVioR ok. I've updated the pull request to pass the style checks.

@HeartSaVioR
Copy link
Contributor

The code itself looks good, but I'm not familiar with Cassandra so not convinced to vote +1 on this.
cc. ing storm-calcite sponsors @ptgoetz @harshach

@HeartSaVioR
Copy link
Contributor

Seems like I should just merge it. +1 again.

@asfgit asfgit merged commit d16c821 into apache:master Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants