STORM-2443 Fix issues on changing log level #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satishd
reviewed
Aug 30, 2017
There was a problem hiding this comment.
@HeartSaVioR LGTM, you may want to add tests in LogConfigManagerTest for this fix?
|
@satishd Sure. I missed that. Will address. |
* Addressed below issues
* Nimbus throws error when changing log level on UI topology page
* Log configs in worker are removed even they're not timed out and never reset
* The unit of epoch between backend and frontend are different
* second in backend, millisecond in frontend
* millisecond is right so fixed it
HeartSaVioR
force-pushed
the
STORM-2443
branch
from
01fbb1a
to
9d62c13
Compare
|
@satishd Addressed and squashed commits. |
|
It seems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The above issues seem to be only in master branch.