Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORM-2862: More flexible logging in multilang #2474

Merged
merged 1 commit into from Jan 22, 2018

Conversation

@hmcc
Copy link
Contributor

hmcc commented Dec 20, 2017

Connected to https://issues.apache.org/jira/browse/STORM-2862.
Put contextual information in the ThreadContext for multilang logging.

I've updated the Python and Ruby resources in multilang, but not the JS one. That's because the JS one is written to support variable arguments (probably because of STORM-2435). I can't see a way to support optional IDs without breaking the current behaviour.

@hmcc hmcc force-pushed the hmcc:STORM-2862-1.x branch from 92511b9 to 835a3f3 Dec 20, 2017
@hmcc hmcc force-pushed the hmcc:STORM-2862-1.x branch from 6994bd6 to 6e5d90e Jan 9, 2018
@hmcc hmcc force-pushed the hmcc:STORM-2862-1.x branch 2 times, most recently from 83d4e5e to a614946 Jan 19, 2018
@hmcc hmcc force-pushed the hmcc:STORM-2862-1.x branch from a614946 to 5f595cb Jan 22, 2018
@asfgit asfgit merged commit 5f595cb into apache:1.x-branch Jan 22, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@HeartSaVioR

This comment has been minimized.

Copy link
Contributor

HeartSaVioR commented Jan 22, 2018

+1 prior to merge. (It's kind of porting back.)

@hmcc hmcc deleted the hmcc:STORM-2862-1.x branch Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.