STORM-2909 port new metrics to 2.x branch #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartSaVioR
reviewed
Apr 9, 2018
There was a problem hiding this comment.
Looks great. I compared this with #2203 by side to side, though this contains huge lines of additional style fixes. Left minor comments.
| @@ -223,7 +224,7 @@ private Object loadWorker(Map<String, Object> topologyConf, IStateStorage stateS | |||
|
|
|||
|
|
|||
| // This thread will send out messages destined for remote tasks (on other workers) | |||
| if ( ( (Long)topologyConf.get(Config.TOPOLOGY_WORKERS) ) > 1 ) { | |||
| if (((Long)topologyConf.get(Config.TOPOLOGY_WORKERS)) > 1) { | |||
There was a problem hiding this comment.
Please rebase with latest master.
|
|
||
| @Override | ||
| public void prepare(Map<String, Object> StormConf){ | ||
| public void prepare(Map stormConf){ |
There was a problem hiding this comment.
Please keep exposing generic type if possible.
|
Could you take up copying documentation from another PR as well, based on #2526? |
agresch
force-pushed
the
agresch_newmetrics_port
branch
from
f35c5c7
to
21da5df
Compare
|
@HeartSaVioR made the changes you suggested. I can look at the documentation changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ptgoetz
Ported the new metrics code from 1.2 to 2.x. Verified ConsoleReporter spit out some of the new metrics.