Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STORM-3235] Fix WorkerToken renewal criteria and refactor #2850

Merged
merged 1 commit into from
Sep 28, 2018
Merged

[STORM-3235] Fix WorkerToken renewal criteria and refactor #2850

merged 1 commit into from
Sep 28, 2018

Conversation

kishorvpatil
Copy link
Contributor

  • Fix broken condition to validate if new WorkerToken should be added.
  • Refactor code out of Nimbus into WorkerTokenManager
  • Updated WorkerTokenTest to ensure WorkerTokenManager recognizes token ready for renewal.

revans2
revans2 approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 this is a lot clearer than the code I had originally written, because we obviously missed a bug in the old code.

@asfgit asfgit merged commit 24a28ea into apache:master Sep 28, 2018
asfgit pushed a commit that referenced this pull request Sep 28, 2018
Merge branch 'storm3235' of https://github.com/kishorvpatil/incubator…
53434b7 
…-storm into STORM-3235

STORM-3235: Fix WorkerToken renewal criteria and refactor

This closes #2850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kishorvpatil @revans2 @asfgit