Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORM-3352: Lock Netty versions using Netty BOM #2969

Merged
merged 1 commit into from Mar 16, 2019

Conversation

@srdo
Copy link
Contributor

commented Mar 7, 2019

https://issues.apache.org/jira/browse/STORM-3352

The dependency tree for storm-cassandra previously showed

org.apache.storm:storm-cassandra:jar:2.0.1-SNAPSHOT
[INFO] +- com.datastax.cassandra:cassandra-driver-core:jar:3.1.2:provided
[INFO] |  +- io.netty:netty-handler:jar:4.0.37.Final:provided
[INFO] |  |  +- io.netty:netty-buffer:jar:4.0.37.Final:provided
[INFO] |  |  |  \- io.netty:netty-common:jar:4.0.37.Final:provided
[INFO] |  |  +- io.netty:netty-transport:jar:4.0.37.Final:provided
[INFO] |  |  \- io.netty:netty-codec:jar:4.0.37.Final:provided
...
- io.netty:netty-all:jar:4.1.30.Final:test

which is likely to cause issues.

@srdo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

The test failure occurs when running mvn install -Pall-tests,externals,examples in the project root, when storm-cassandra is tested.

@srdo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

Build passed for me locally and on Travis https://travis-ci.org/srdo/storm/builds/502966339
Edit: Hm, travis build had a test failure. It looks unrelated.

Copy link
Contributor

left a comment

👍

@HeartSaVioR

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

Just reran failed builds in Travis to see whether the failure is intermittent or not.
(Now we have write privilege so we can rerun tests in Travis CI.)

@srdo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

I think the Slot assertion bug/AsyncLocalizer deadlock (#2943) is more likely to happen now that LocalCluster timers have had their intervals reduced. I think that is the reason for the instability.

@srdo srdo force-pushed the srdo:STORM-3352 branch from bb79b85 to 7cfea68 Mar 15, 2019
@srdo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

Test failure is due to Travis failing to connect to an apt repo. Rerunning.

@srdo srdo force-pushed the srdo:STORM-3352 branch from 7cfea68 to d4b53b7 Mar 15, 2019
Copy link
Contributor

left a comment

+1

> grep "io.netty:" dependency-tree.log | grep "4.1"

[INFO] +- io.netty:netty-all:jar:4.1.30.Final:compile (optional)
[INFO] |     +- io.netty:netty-all:jar:4.1.30.Final:compile
[INFO] |  +- io.netty:netty-all:jar:4.1.30.Final:compile
[INFO] |  +- io.netty:netty-all:jar:4.1.30.Final:compile
[INFO] |  |     +- io.netty:netty-all:jar:4.1.30.Final:compile
[INFO] |     +- io.netty:netty-all:jar:4.1.30.Final:compile
[INFO] |  |  +- io.netty:netty-all:jar:4.1.30.Final:test
[INFO] |  +- io.netty:netty-handler:jar:4.1.30.Final:provided
[INFO] |  |  +- io.netty:netty-buffer:jar:4.1.30.Final:provided
[INFO] |  |  |  \- io.netty:netty-common:jar:4.1.30.Final:provided
[INFO] |  |  +- io.netty:netty-transport:jar:4.1.30.Final:provided
[INFO] |  |  |  \- io.netty:netty-resolver:jar:4.1.30.Final:provided
[INFO] |  |  \- io.netty:netty-codec:jar:4.1.30.Final:provided
[INFO] |  \- io.netty:netty-all:jar:4.1.30.Final:test
[INFO] |  |     \- io.netty:netty-all:jar:4.1.30.Final:compile
[INFO] |  +- io.netty:netty-all:jar:4.1.30.Final:compile
[INFO] |  |  +- io.netty:netty-all:jar:4.1.30.Final:test
[INFO] |  |  +- io.netty:netty-all:jar:4.1.30.Final:compile
[INFO] |  |  +- io.netty:netty-all:jar:4.1.30.Final:provided
[INFO] |  |  +- io.netty:netty-all:jar:4.1.30.Final:compile
[INFO] |  |  +- io.netty:netty-all:jar:4.1.30.Final:compile
[INFO] |  |  |     +- io.netty:netty-all:jar:4.1.30.Final:compile
[INFO] |  |     +- io.netty:netty-all:jar:4.1.30.Final:compile
[INFO] |  |  |     \- io.netty:netty-all:jar:4.1.30.Final:compile
[INFO] |  |  +- io.netty:netty-all:jar:4.1.30.Final:compile
@asfgit asfgit merged commit d4b53b7 into apache:master Mar 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.