From b01bc8ed201f258fdc324698824411483fc63e9d Mon Sep 17 00:00:00 2001
From: Ethan Li <ethanopensource@gmail.com>
Date: Wed, 30 Oct 2019 11:34:42 -0500
Subject: [PATCH 1/2] MINOR: create a checklist for testing a new Storm release

---
 RELEASING.md | 26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/RELEASING.md b/RELEASING.md
index 06f2012ba3f..91eab9b647b 100644
--- a/RELEASING.md
+++ b/RELEASING.md
@@ -1,7 +1,6 @@
-# Committer documentation
+# Release
 
-This document summarizes information relevant to Storm committers.  It includes information about
-the Storm release process.
+This document includes information about the Storm release process.
 
 ---
 
@@ -85,3 +84,24 @@ gpg --print-md SHA512 RELEASE_NOTES.html > RELEASE_NOTES.html.sha512
 2. Delete the staged distribution files from https://dist.apache.org/repos/dist/dev/storm/
 
 3. Delete the git tag.
+
+# How to vote on a release candidate
+
+We encourage everyone to review and vote on a release candidate to make an Apache Storm release more reliable and trustworthy.
+
+Below is a checklist that one could do to review a release candidate. 
+Please note this list is not exhaustive and only includes some of the common steps. Feel free to add your own tests.
+
+1. Verify files such as *.asc, *.sha512;
+2. Build Apache Storm source code and run unit tests, create an Apache Storm distribution;
+3. Set up a standalone cluster using apache-storm-xxx.zip, apache-storm-xxx.tar.gz, the Apache Storm distribution created from step 2, separately;
+4. Launch WordCountTopology and ThroughputVsLatency topology and check logs, UI metrics, etc;
+5. Test basic UI functionalities such as jstack, heap dump, deactivate, activate, rebalance, change log level, log search, kill topology;
+6. Test basic CLI such as kill, list, deactivate, deactivate, rebalance, etc.
+
+It's also preferable to set up a standalone secure Apache Storm cluster and test basic funcionalities on it.
+
+Don't feel the pressure to do everything listed above. After you finish your review, reply to the corresponding email thread with your vote, summarize the work you have performed and elaborate the issues
+you have found if any. Also please feel free to update the checklist if you think anything important is missing there. 
+
+Your contribution is very much appreciated.  
\ No newline at end of file

From 595c55d8c7f651271ab9d77a8f9d71390181638b Mon Sep 17 00:00:00 2001
From: Ethan Li <ethanopensource@gmail.com>
Date: Thu, 31 Oct 2019 09:22:04 -0500
Subject: [PATCH 2/2] MINOR: add link to dev-tools/rc and remove MD5 file check

---
 RELEASING.md                        |  2 +-
 dev-tools/rc/verify-release-file.sh | 15 ---------------
 2 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/RELEASING.md b/RELEASING.md
index 91eab9b647b..6affa3ab346 100644
--- a/RELEASING.md
+++ b/RELEASING.md
@@ -92,7 +92,7 @@ We encourage everyone to review and vote on a release candidate to make an Apach
 Below is a checklist that one could do to review a release candidate. 
 Please note this list is not exhaustive and only includes some of the common steps. Feel free to add your own tests.
 
-1. Verify files such as *.asc, *.sha512;
+1. Verify files such as *.asc, *.sha512; some scripts are available under `dev-tools/rc` to help with it;
 2. Build Apache Storm source code and run unit tests, create an Apache Storm distribution;
 3. Set up a standalone cluster using apache-storm-xxx.zip, apache-storm-xxx.tar.gz, the Apache Storm distribution created from step 2, separately;
 4. Launch WordCountTopology and ThroughputVsLatency topology and check logs, UI metrics, etc;
diff --git a/dev-tools/rc/verify-release-file.sh b/dev-tools/rc/verify-release-file.sh
index 2e33965a656..3e6a8690b18 100755
--- a/dev-tools/rc/verify-release-file.sh
+++ b/dev-tools/rc/verify-release-file.sh
@@ -34,21 +34,6 @@ else
   echo 'Signature seems not correct'
 fi
 
-# checking MD5
-GPG_MD5_FILE="/tmp/${TARGET_FILE}_GPG.md5"
-gpg --print-md MD5 ${TARGET_FILE} > ${GPG_MD5_FILE}
-MD5_TARGET_FILE="${TARGET_FILE}.md5"
-
-echo ">> checking MD5 file... (${MD5_TARGET_FILE})"
-diff ${GPG_MD5_FILE} ${MD5_TARGET_FILE}
-
-if [ $? -eq 0 ];
-then
-  echo 'MD5 file is correct'
-else
-  echo 'MD5 file is not correct'
-fi
-
 # checking SHA
 GPG_SHA_FILE="/tmp/${TARGET_FILE}_GPG.sha512"
 gpg --print-md SHA512 ${TARGET_FILE} > ${GPG_SHA_FILE}