STORM-3540 fix Pacemaker connection issues #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdo
reviewed
Nov 21, 2019
| @@ -72,7 +72,7 @@ protected void initChannel(Channel ch) throws Exception { | |||
| throw new RuntimeException(e); | |||
| } | |||
| } else { | |||
| client.channelReady(ch); | |||
| // no work for AuthMethod.NONE | |||
There was a problem hiding this comment.
Consider removing the else block entirely
There was a problem hiding this comment.
My personal preference is to leave it so we know AuthMethod.NONE was not skipped by accident.
|
+1, good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Exception occurred in Pacemaker" message was not logging cause properly until I changed the message for some reason.
Problem:
The solution I think is more appropriate:
PacemakerClientHandler.channelActive() should be the one calling PacemakerClient.channelReady().