[STORM-991] General cleanup of the generics. #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,7 +56,7 @@ public RichSpoutBatchTriggerer(IRichSpout delegate, String streamName, String ba | |||
| @Override | |||
| public void open(Map conf, TopologyContext context, SpoutOutputCollector collector) { | |||
| _delegate.open(conf, context, new SpoutOutputCollector(new StreamOverrideCollector(collector))); | |||
| _outputTasks = new ArrayList<Integer>(); | |||
| _outputTasks = new ArrayList<>(); | |||
There was a problem hiding this comment.
On a different PR someone pointed out that this is syntax required Java 1.7 That seems ok to me since the top level pom.xml specifies 1.7 in the compile plugin, but I wanted to just point that fact out.
I support moving to the diamond notation since it makes the code much cleaner, in my opinion.
|
Issue raised on Jira: https://issues.apache.org/jira/browse/STORM-991 |
ddebree
changed the title
ddebree
changed the title
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally added generics to classes within the storm.trident.spout package. This generally removes some of the casts that were in place, and simplifies the code slightly.
A typical example of what was done is
was converted to: