Fix thread safety: replace shared Matcher and SimpleDateFormat instances #1929
Merged
Conversation
…ances - RefreshTag: replace static shared Matcher with Pattern + per-call Matcher - FileResponse: replace SimpleDateFormat with DateTimeFormatter; use try-with-resources for FileInputStream - CookieConverter: replace SimpleDateFormat with DateUtils.parseDate(); fix duplicate setExpiryDate() call; add null guard on parsed date
rzo1
approved these changes
Jun 4, 2026
jnioche
approved these changes
Jun 5, 2026
| // check that it hasn't expired? | ||
| if (cookie.isExpired(new Date())) { | ||
| continue; | ||
| Date expirationDate = org.apache.http.client.utils.DateUtils.parseDate(expires); |
Contributor
There was a problem hiding this comment.
we have dependencies on o.a.httpclient in various places, it is acceptable to have it here too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimpleDateFormatand sharedMatcherinstances are not thread-safe.In a multi-threaded Storm topology this can cause silent data corruption
or incorrect results under concurrent load.
RefreshTag: replace static sharedMatcherwith aPatternconstantand a per-call
MatcherinstanceFileResponse: replaceSimpleDateFormatwithDateTimeFormatter(also use try-with-resources for
FileInputStreamin the same class)CookieConverter: replaceSimpleDateFormatwithDateUtils.parseDate();also fix a duplicate
setExpiryDate()call and add a null guard on theparsed date