Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-764. Fix environment spec parse errors #540

Closed
wants to merge 5 commits into from

Conversation

KUAN-HSUN-LI
Copy link
Member

What is this PR for?

  • Support pip dependencies in kernel spec
  • Change the old dependencies in kernel spec to condaDependencies

What type of PR is it?

[Improvement]

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-764

How should this be tested?

run the following command

curl -X POST -H "Content-Type: application/json" -d '
{
  "name": "my-submarine-env1",
  "dockerImage" : "continuumio/anaconda3",
  "kernelSpec" : {
    "name" : "team_default_python_3.7",
    "channels" : ["defaults"],
    "condaDependencies" : 
      ["_ipyw_jlab_nb_ext_conf=0.1.0=py37_0",
      "alabaster=0.7.12=py37_0",
      "anaconda=2020.02=py37_0",
      "anaconda-client=1.7.2=py37_0",
      "anaconda-navigator=1.9.12=py37_0"],
    "pipDependencies" : 
      ["apache-submarine==0.5.0",
       "pyarrow==0.17.0"]
  }
}
' http://127.0.0.1:32080/api/v1/environment

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? Yes
  • Does this needs documentation? No

@KUAN-HSUN-LI KUAN-HSUN-LI changed the title Submarine-764. Fix environment spec parse errors SUBMARINE-764. Fix environment spec parse errors Mar 22, 2021
@KUAN-HSUN-LI
Copy link
Member Author

@pingsutw Could you please help me review this PR, thanks!

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KUAN-HSUN-LI Thanks for your contribution
Some comments in the below.

@KUAN-HSUN-LI
Copy link
Member Author

@pingsutw Thanks! I have added.

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks @KUAN-HSUN-LI
Could you also create a JIRA ticket that updates the environment docs?
https://submarine.apache.org/docs/api/environment

@asfgit asfgit closed this in 31f8d33 Apr 5, 2021
asfgit pushed a commit that referenced this pull request Apr 13, 2021
### What is this PR for?
The environment API changes in #540 .
Updates the API in environment docs.

### What type of PR is it?
[Documentation]

### Todos

### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-785

### How should this be tested?

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: KUAN-HSUN-LI <b06209027@ntu.edu.tw>

Signed-off-by: Liu Xun <liuxun@apache.org>

Closes #549 from KUAN-HSUN-LI/SUBMARINE-785 and squashes the following commits:

dc3af1a [KUAN-HSUN-LI] SUBMARINE-785. Updates the environment docs by adding pip dependencies
asfgit pushed a commit that referenced this pull request May 3, 2021
### What is this PR for?
1. Improve the UI, created in #534
2. Parse the uploaded conda config file
3. Enable the updated API in #540
4. remove the kernelSpec block
### What type of PR is it?
[Improvement]

### Todos
- [ ] (test the parsing function)

### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-785

### How should this be tested?

### Screenshots (if appropriate)
![2021-04-05 21-24-40](https://user-images.githubusercontent.com/38066413/113591762-e784c200-9666-11eb-8bee-e9fa6e629894.gif)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? Yes
* Does this needs documentation? No

Author: KUAN-HSUN-LI <b06209027@ntu.edu.tw>

Signed-off-by: Liu Xun <liuxun@apache.org>

Closes #550 from KUAN-HSUN-LI/SUBMARINE-774 and squashes the following commits:

3fef78d [KUAN-HSUN-LI] SUBMARINE-774. Update environment e2e environment test resourse's License
bd90979 [KUAN-HSUN-LI] SUBMARINE-774. Update environment e2e test
b0984cf [KUAN-HSUN-LI] SUBMARINE-774. Change error msg
eb526ad [KUAN-HSUN-LI] SUBMARINE-774. Support parsing conda config file
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants