This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 254
SUBMARINE-764. Fix environment spec parse errors #540
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KUAN-HSUN-LI
changed the title
Submarine-764. Fix environment spec parse errors
SUBMARINE-764. Fix environment spec parse errors
Mar 22, 2021
@pingsutw Could you please help me review this PR, thanks! |
pingsutw
reviewed
Apr 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KUAN-HSUN-LI Thanks for your contribution
Some comments in the below.
...erver/server-core/src/test/java/org/apache/submarine/server/rest/EnvironmentRestApiTest.java
Show resolved
Hide resolved
...server/server-core/src/test/java/org/apache/submarine/server/rest/ExperimentRestApiTest.java
Outdated
Show resolved
Hide resolved
...r-k8s/src/main/java/org/apache/submarine/server/submitter/k8s/parser/NotebookSpecParser.java
Outdated
Show resolved
Hide resolved
pingsutw
reviewed
Apr 3, 2021
...erver/server-core/src/test/java/org/apache/submarine/server/rest/EnvironmentRestApiTest.java
Show resolved
Hide resolved
@pingsutw Thanks! I have added. |
pingsutw
approved these changes
Apr 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thanks @KUAN-HSUN-LI
Could you also create a JIRA ticket that updates the environment docs?
https://submarine.apache.org/docs/api/environment
This was referenced Apr 5, 2021
asfgit
pushed a commit
that referenced
this pull request
Apr 13, 2021
### What is this PR for? The environment API changes in #540 . Updates the API in environment docs. ### What type of PR is it? [Documentation] ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/SUBMARINE-785 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: KUAN-HSUN-LI <b06209027@ntu.edu.tw> Signed-off-by: Liu Xun <liuxun@apache.org> Closes #549 from KUAN-HSUN-LI/SUBMARINE-785 and squashes the following commits: dc3af1a [KUAN-HSUN-LI] SUBMARINE-785. Updates the environment docs by adding pip dependencies
asfgit
pushed a commit
that referenced
this pull request
May 3, 2021
### What is this PR for? 1. Improve the UI, created in #534 2. Parse the uploaded conda config file 3. Enable the updated API in #540 4. remove the kernelSpec block ### What type of PR is it? [Improvement] ### Todos - [ ] (test the parsing function) ### What is the Jira issue? https://issues.apache.org/jira/browse/SUBMARINE-785 ### How should this be tested? ### Screenshots (if appropriate) ![2021-04-05 21-24-40](https://user-images.githubusercontent.com/38066413/113591762-e784c200-9666-11eb-8bee-e9fa6e629894.gif) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? Yes * Does this needs documentation? No Author: KUAN-HSUN-LI <b06209027@ntu.edu.tw> Signed-off-by: Liu Xun <liuxun@apache.org> Closes #550 from KUAN-HSUN-LI/SUBMARINE-774 and squashes the following commits: 3fef78d [KUAN-HSUN-LI] SUBMARINE-774. Update environment e2e environment test resourse's License bd90979 [KUAN-HSUN-LI] SUBMARINE-774. Update environment e2e test b0984cf [KUAN-HSUN-LI] SUBMARINE-774. Change error msg eb526ad [KUAN-HSUN-LI] SUBMARINE-774. Support parsing conda config file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-764
How should this be tested?
run the following command
Screenshots (if appropriate)
Questions: