diff --git a/superset-frontend/src/explore/components/ExploreChartHeader/index.jsx b/superset-frontend/src/explore/components/ExploreChartHeader/index.jsx index 17a78d20c150..d9d615dc1f33 100644 --- a/superset-frontend/src/explore/components/ExploreChartHeader/index.jsx +++ b/superset-frontend/src/explore/components/ExploreChartHeader/index.jsx @@ -54,8 +54,8 @@ const CHART_STATUS_MAP = { const propTypes = { actions: PropTypes.object.isRequired, - can_overwrite: PropTypes.bool.isRequired, - can_download: PropTypes.bool.isRequired, + canOverwrite: PropTypes.bool.isRequired, + canDownload: PropTypes.bool.isRequired, dashboardId: PropTypes.number, isStarred: PropTypes.bool.isRequired, slice: PropTypes.object, @@ -178,11 +178,6 @@ export class ExploreChartHeader extends React.PureComponent { .catch(() => {}); } - getSliceName() { - const { sliceName, table_name: tableName } = this.props; - return sliceName || t('%s - untitled', tableName); - } - postChartFormData() { this.props.actions.postChartFormData( this.props.form_data, @@ -224,30 +219,43 @@ export class ExploreChartHeader extends React.PureComponent { } render() { - const { user, form_data: formData, slice } = this.props; + const { + actions, + chart, + user, + formData, + slice, + canOverwrite, + canDownload, + isStarred, + sliceUpdated, + sliceName, + } = this.props; const { chartStatus, chartUpdateEndTime, chartUpdateStartTime, latestQueryFormData, queriesResponse, - } = this.props.chart; + sliceFormData, + } = chart; // TODO: when will get appropriate design for multi queries use all results and not first only const queryResponse = queriesResponse?.[0]; + const oldSliceName = slice?.slice_name; const chartFinished = ['failed', 'rendered', 'success'].includes( - this.props.chart.chartStatus, + chartStatus, ); return (
{slice?.certified_by && ( @@ -258,14 +266,14 @@ export class ExploreChartHeader extends React.PureComponent { />{' '} )} - {this.props.slice && ( + {slice && ( {user.userId && ( )} @@ -273,15 +281,15 @@ export class ExploreChartHeader extends React.PureComponent { )} - {this.props.chart.sliceFormData && ( + {sliceFormData && ( )} @@ -307,10 +315,10 @@ export class ExploreChartHeader extends React.PureComponent { status={CHART_STATUS_MAP[chartStatus]} /> diff --git a/superset-frontend/src/explore/components/ExploreViewContainer/index.jsx b/superset-frontend/src/explore/components/ExploreViewContainer/index.jsx index 0e111b2b573a..57437ea99f88 100644 --- a/superset-frontend/src/explore/components/ExploreViewContainer/index.jsx +++ b/superset-frontend/src/explore/components/ExploreViewContainer/index.jsx @@ -548,14 +548,14 @@ function ExploreViewContainer(props) {