From 3208a014ffccfe44238fb5982f6e391a1764d4b3 Mon Sep 17 00:00:00 2001 From: yileic Date: Tue, 9 May 2017 17:44:08 -0700 Subject: [PATCH] fix dual line chart margin (#2737) --- superset/assets/visualizations/nvd3_vis.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/superset/assets/visualizations/nvd3_vis.js b/superset/assets/visualizations/nvd3_vis.js index aa49d437f560..d1c601f249b7 100644 --- a/superset/assets/visualizations/nvd3_vis.js +++ b/superset/assets/visualizations/nvd3_vis.js @@ -406,10 +406,11 @@ function nvd3Vis(slice, payload) { .style('fill-opacity', 1); } - if (chart.yAxis !== undefined) { + if (chart.yAxis !== undefined || chart.yAxis2 !== undefined) { // Hack to adjust y axis left margin to accommodate long numbers const marginPad = isExplore ? width * 0.01 : width * 0.03; - const maxYAxisLabelWidth = getMaxLabelSize(slice.container, 'nv-y'); + const maxYAxisLabelWidth = chart.yAxis2 ? getMaxLabelSize(slice.container, 'nv-y1') + : getMaxLabelSize(slice.container, 'nv-y'); const maxXAxisLabelHeight = getMaxLabelSize(slice.container, 'nv-x'); chart.margin({ left: maxYAxisLabelWidth + marginPad }); if (fd.y_axis_label && fd.y_axis_label !== '') {