From 126d409b65fb4b9ebb79f06b399c064eed69a739 Mon Sep 17 00:00:00 2001 From: Kartik Khare Date: Thu, 26 Sep 2019 12:46:33 +0530 Subject: [PATCH] fix: Line not hidden after legend selection (#204) * fix: Line not hidden after legend selection * fix: lint issues --- .../src/NVD3Vis.js | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js index 4e3b2d405a47..d87af915b3dc 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js @@ -1080,13 +1080,15 @@ function nvd3Vis(element, props) { .call(chart); // Display styles for Time Series Annotations - d3.selectAll('.slice_container .nv-timeseries-annotation-layer.showMarkerstrue .nv-point') - .style('stroke-opacity', 1) - .style('fill-opacity', 1); - d3.selectAll('.slice_container .nv-timeseries-annotation-layer.hideLinetrue').style( - 'stroke-width', - 0, - ); + chart.dispatch.on('renderEnd.timeseries-annotation', () => { + d3.selectAll('.slice_container .nv-timeseries-annotation-layer.showMarkerstrue .nv-point') + .style('stroke-opacity', 1) + .style('fill-opacity', 1); + d3.selectAll('.slice_container .nv-timeseries-annotation-layer.hideLinetrue').style( + 'stroke-width', + 0, + ); + }); } }