Catch colors when theme top level (#19571)

apache · Apr 8, 2022 · 16f193c · 16f193c
1 parent 761d5c4
commit 16f193c
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/superset-frontend/tools/eslint-plugin-theme-colors/index.js b/superset-frontend/tools/eslint-plugin-theme-colors/index.js
@@ -72,14 +72,19 @@ module.exports = {
         return {
           TemplateElement(node) {
             const rawValue = node?.value?.raw;
-            const isParentProperty =
+            const isChildParentTagged =
               node?.parent?.parent?.type === 'TaggedTemplateExpression';
+            const isChildParentArrow =
+              node?.parent?.parent?.type === 'ArrowFunctionExpression';
+            const isParentTemplateLiteral =
+              node?.parent?.type === 'TemplateLiteral';
             const loc = node?.parent?.parent?.loc;
             const locId = loc && JSON.stringify(loc);
             const hasWarned = warned.includes(locId);
             if (
               !hasWarned &&
-              isParentProperty &&
+              (isChildParentTagged ||
+                (isChildParentArrow && isParentTemplateLiteral)) &&
               rawValue &&
               (hasLiteralColor(rawValue) ||
                 hasHexColor(rawValue) ||