From 294a469dacbbf5864f872120f56163c64f23e25e Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Fri, 1 Jul 2016 16:35:02 -0700 Subject: [PATCH] Revert "Binding key Q to the running the query in explore view" --- caravel/assets/javascripts/explore.js | 12 ------------ docs/faq.rst | 6 ------ 2 files changed, 18 deletions(-) diff --git a/caravel/assets/javascripts/explore.js b/caravel/assets/javascripts/explore.js index 28b76cd000e8..f9033d0532fe 100644 --- a/caravel/assets/javascripts/explore.js +++ b/caravel/assets/javascripts/explore.js @@ -8,8 +8,6 @@ var jQuery = window.jQuery = $; var px = require('./modules/caravel.js'); var showModal = require('./modules/utils.js').showModal; -var isQueryRunning = false; - require('jquery-ui'); $.widget.bridge('uitooltip', $.ui.tooltip); // Shutting down jq-ui tooltips require('bootstrap'); @@ -58,10 +56,6 @@ function prepForm() { } function query(force, pushState) { - if (isQueryRunning) { - return; - } - isQueryRunning = true; if (force === undefined) { force = false; } @@ -77,7 +71,6 @@ function query(force, pushState) { history.pushState({}, document.title, slice.querystring()); } slice.render(force); - isQueryRunning = false; } function initExploreView() { @@ -489,9 +482,4 @@ $(document).ready(function () { $('div.toggle').addClass('pull-right'); slice.bindResizeToWindowResize(); - document.addEventListener("keyup", function (k) { - if (k.key === 'q' || k.key === 'Q') { - query(true); - } - }); }); diff --git a/docs/faq.rst b/docs/faq.rst index a733e9f5ae2b..fc4e2b820019 100644 --- a/docs/faq.rst +++ b/docs/faq.rst @@ -43,9 +43,3 @@ framework, in the meantime, we've tagged a few pull requests as visualizations. https://github.com/airbnb/caravel/issues?q=label%3Aexample+is%3Aclosed - - -Is there shortcut for the Query button --------------------------------------- - -Yes, `q` or `Q` will do it.