From 346c035690524f564421af6c18e4911c9ee5a268 Mon Sep 17 00:00:00 2001 From: Kamil Gabryjelski Date: Wed, 3 Aug 2022 21:55:52 +0200 Subject: [PATCH] fix: Explore scrolled down when navigating from dashboard (#20962) (cherry picked from commit e4fc5564ced1e2ad2f475629ce082ededd063ba9) --- superset-frontend/src/views/App.tsx | 2 ++ superset-frontend/src/views/ScrollToTop.tsx | 31 +++++++++++++++++++++ 2 files changed, 33 insertions(+) create mode 100644 superset-frontend/src/views/ScrollToTop.tsx diff --git a/superset-frontend/src/views/App.tsx b/superset-frontend/src/views/App.tsx index 04ca777c3d7a..ecdbddbd5679 100644 --- a/superset-frontend/src/views/App.tsx +++ b/superset-frontend/src/views/App.tsx @@ -35,6 +35,7 @@ import setupApp from 'src/setup/setupApp'; import { routes, isFrontendRoute } from 'src/views/routes'; import { Logger } from 'src/logger/LogUtils'; import { RootContextProviders } from './RootContextProviders'; +import { ScrollToTop } from './ScrollToTop'; setupApp(); @@ -60,6 +61,7 @@ const LocationPathnameLogger = () => { const App = () => ( + diff --git a/superset-frontend/src/views/ScrollToTop.tsx b/superset-frontend/src/views/ScrollToTop.tsx new file mode 100644 index 000000000000..283f1b4208f7 --- /dev/null +++ b/superset-frontend/src/views/ScrollToTop.tsx @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { useEffect } from 'react'; +import { useLocation } from 'react-router-dom'; + +export const ScrollToTop = () => { + const { pathname } = useLocation(); + + useEffect(() => { + window.scrollTo(0, 0); + }, [pathname]); + + return null; +};