Skip to content

Commit

Permalink
feat: Adds a separator to Select All option
Browse files Browse the repository at this point in the history
  • Loading branch information
michael-s-molina committed Jan 19, 2023
1 parent 577ac81 commit 5012b5e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion superset-frontend/.storybook/preview.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -87,5 +87,5 @@ addParameters({
],
},
},
controls: { expanded: true },
controls: { expanded: true, sort: 'alpha' },
});
1 change: 1 addition & 0 deletions superset-frontend/src/components/Select/Select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,7 @@ const Select = forwardRef(
{selectAllEnabled && (
<Option
id="select-all"
className="select-all"
key={SELECT_ALL_VALUE}
value={SELECT_ALL_VALUE}
>
Expand Down
4 changes: 3 additions & 1 deletion superset-frontend/src/components/Select/styles.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ export const StyledSelect = styled(AntdSelect, {
.ant-select-arrow .anticon:not(.ant-select-suffix) {
pointer-events: none;
}
.select-all {
border-bottom: 1px solid ${theme.colors.grayscale.light3};
}
${
oneLine &&
`
Expand Down

0 comments on commit 5012b5e

Please sign in to comment.