From 50d80405a90c9c79f2a00b2c22cc6c1fdc333012 Mon Sep 17 00:00:00 2001 From: Daniel Vaz Gaspar Date: Thu, 1 Oct 2020 12:35:12 +0100 Subject: [PATCH] fix: alembic migration error msg trying to delete constraint on tables (#11115) * fix: alembic migration fails by deleting non existent constraint on tables * Revert "fix: alembic migration fails by deleting non existent constraint on tables" This reverts commit 3a359b0577f4bf33992c3de2d54e8546bd3d216f. * mantain migration but just for MySQL and add downgrade procedure * skip the downgrade --- .../18532d70ab98_fix_table_unique_constraint_in_mysql.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/superset/migrations/versions/18532d70ab98_fix_table_unique_constraint_in_mysql.py b/superset/migrations/versions/18532d70ab98_fix_table_unique_constraint_in_mysql.py index f4c5af19dc94..c011c06eec65 100644 --- a/superset/migrations/versions/18532d70ab98_fix_table_unique_constraint_in_mysql.py +++ b/superset/migrations/versions/18532d70ab98_fix_table_unique_constraint_in_mysql.py @@ -27,15 +27,15 @@ down_revision = "3fbbc6e8d654" from alembic import op +from sqlalchemy.dialects.mysql.base import MySQLDialect def upgrade(): - try: + bind = op.get_bind() + if isinstance(bind.dialect, MySQLDialect): # index only exists in mysql db with op.get_context().autocommit_block(): op.drop_constraint("table_name", "tables", type_="unique") - except Exception as ex: - print(ex) def downgrade():