From 631c867c467f6cdcb350cf4e7d1caf2f4566ba80 Mon Sep 17 00:00:00 2001 From: Yaozong Liu <750188453@qq.com> Date: Tue, 20 Jul 2021 11:54:56 +0800 Subject: [PATCH] feat(plugin-chart-table): table x-filtering supports single select (#1220) * fix(plugin-chart-echarts): table support single select * fix: remove comments --- .../plugins/plugin-chart-table/src/TableChart.tsx | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-table/src/TableChart.tsx b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-table/src/TableChart.tsx index a60e6e022c54..b925dcdd8af1 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-table/src/TableChart.tsx +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-table/src/TableChart.tsx @@ -234,11 +234,13 @@ export default function TableChart( const toggleFilter = useCallback( function toggleFilter(key: string, val: DataRecordValue) { - const updatedFilters = { ...(filters || {}) }; + let updatedFilters = { ...(filters || {}) }; if (filters && isActiveFilterValue(key, val)) { - updatedFilters[key] = filters[key].filter((x: DataRecordValue) => x !== val); + updatedFilters = {}; } else { - updatedFilters[key] = [...(filters?.[key] || []), val]; + updatedFilters = { + [key]: [val], + }; } if (Array.isArray(updatedFilters[key]) && updatedFilters[key].length === 0) { delete updatedFilters[key];