From 68ebb111f1fc880607b5b65695a20fbdd7af26b8 Mon Sep 17 00:00:00 2001 From: Krist Wongsuphasawat Date: Wed, 8 May 2019 01:18:25 -0700 Subject: [PATCH] feat: bring lazy import back (#84) --- .../packages/superset-ui-preset-chart-xy/src/BoxPlot/index.ts | 3 +-- .../superset-ui-preset-chart-xy/src/BoxPlot/legacy/index.ts | 3 +-- .../packages/superset-ui-preset-chart-xy/src/Line/index.ts | 3 +-- .../superset-ui-preset-chart-xy/src/Line/legacy/index.ts | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/index.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/index.ts index b0c3cdff3a8a..ee02dbbbe428 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/index.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/index.ts @@ -19,12 +19,11 @@ import { ChartPlugin } from '@superset-ui/chart'; import createMetadata from './createMetadata'; import transformProps from './transformProps'; -import Chart from './BoxPlot'; export default class BoxPlotChartPlugin extends ChartPlugin { constructor() { super({ - Chart, + loadChart: () => import('./BoxPlot'), metadata: createMetadata(), transformProps, }); diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/legacy/index.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/legacy/index.ts index 6a64bfbce188..6667d5ccff7d 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/legacy/index.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/legacy/index.ts @@ -19,12 +19,11 @@ import { ChartPlugin } from '@superset-ui/chart'; import createMetadata from '../createMetadata'; import transformProps from './transformProps'; -import Chart from '../BoxPlot'; export default class BoxPlotChartPlugin extends ChartPlugin { constructor() { super({ - Chart, + loadChart: () => import('../BoxPlot'), metadata: createMetadata(true), transformProps, }); diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/index.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/index.ts index bee8f8bf1e3a..9a9681d8fdb0 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/index.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/index.ts @@ -3,13 +3,12 @@ import transformProps from './transformProps'; import createMetadata from './createMetadata'; import buildQuery from './buildQuery'; import ChartFormData from './ChartFormData'; -import Chart from './Line'; export default class LineChartPlugin extends ChartPlugin { constructor() { super({ buildQuery, - Chart, + loadChart: () => import('./Line'), metadata: createMetadata(), transformProps, }); diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/index.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/index.ts index a4c14aa5f7ab..2fe4dafdbcbd 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/index.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/index.ts @@ -1,12 +1,11 @@ import { ChartPlugin } from '@superset-ui/chart'; import transformProps from './transformProps'; import createMetadata from '../createMetadata'; -import Chart from '../Line'; export default class LineChartPlugin extends ChartPlugin { constructor() { super({ - Chart, + loadChart: () => import('../Line'), metadata: createMetadata(true), transformProps, });