From 7b724439b97cfe496348be0e1bc2e4b195186e01 Mon Sep 17 00:00:00 2001 From: John Bodley <4567245+john-bodley@users.noreply.github.com> Date: Mon, 16 Aug 2021 09:01:01 -0700 Subject: [PATCH] chore(pylint): Reenable ungrouped-imports check (#16256) Co-authored-by: John Bodley --- .pylintrc | 1 - scripts/ci_check_no_file_changes.sh | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.pylintrc b/.pylintrc index f7ef308c81e5..7da2df4de3bf 100644 --- a/.pylintrc +++ b/.pylintrc @@ -84,7 +84,6 @@ confidence= disable= missing-docstring, too-many-lines, - ungrouped-imports, import-outside-toplevel, raise-missing-from, too-few-public-methods, diff --git a/scripts/ci_check_no_file_changes.sh b/scripts/ci_check_no_file_changes.sh index e03a6aca54c6..592faa54628b 100755 --- a/scripts/ci_check_no_file_changes.sh +++ b/scripts/ci_check_no_file_changes.sh @@ -34,7 +34,7 @@ REGEXES=() for CHECK in "$@" do if [[ ${CHECK} == "python" ]]; then - REGEX="(^\.github\/workflows\/.*python|^tests\/|^superset\/|^setup\.py|^requirements\/.+\.txt)" + REGEX="(^\.github\/workflows\/.*python|^tests\/|^superset\/|^setup\.py|^requirements\/.+\.txt|^\.pylintrc)" echo "Searching for changes in python files" elif [[ ${CHECK} == "frontend" ]]; then REGEX="(^\.github\/workflows\/.*(frontend|e2e)|^superset-frontend\/)"