diff --git a/superset/assets/src/chart/Chart.jsx b/superset/assets/src/chart/Chart.jsx index e7c0d3f07831..f223174efa52 100644 --- a/superset/assets/src/chart/Chart.jsx +++ b/superset/assets/src/chart/Chart.jsx @@ -221,7 +221,6 @@ class Chart extends React.PureComponent { } diff --git a/superset/assets/src/components/StackTraceMessage.jsx b/superset/assets/src/components/StackTraceMessage.jsx index dbbfdd6dd2ac..71b0972c2558 100644 --- a/superset/assets/src/components/StackTraceMessage.jsx +++ b/superset/assets/src/components/StackTraceMessage.jsx @@ -7,11 +7,9 @@ const propTypes = { message: PropTypes.string, queryResponse: PropTypes.object, showStackTrace: PropTypes.bool, - resolutionLink: PropTypes.string, }; const defaultProps = { showStackTrace: false, - resolutionLink: '', }; class StackTraceMessage extends React.PureComponent { diff --git a/superset/views/core.py b/superset/views/core.py index 086c210abfd9..0ceefe79fca8 100755 --- a/superset/views/core.py +++ b/superset/views/core.py @@ -1083,9 +1083,9 @@ def generate_json(self, datasource_type, datasource_id, form_data, stacktrace=traceback.format_exc()) if not security_manager.datasource_access(viz_obj.datasource, g.user): - perms_instruction_link = config.get('PERMISSION_INSTRUCTIONS_LINK') return json_error_response( - DATASOURCE_ACCESS_ERR, status=404, link=perms_instruction_link) + DATASOURCE_ACCESS_ERR, status=404, link=config.get( + 'PERMISSION_INSTRUCTIONS_LINK')) if csv: return CsvResponse( @@ -2703,7 +2703,9 @@ def sliceQuery(self, slice_id): """ viz_obj = self.get_viz(slice_id) if not security_manager.datasource_access(viz_obj.datasource): - return json_error_response(DATASOURCE_ACCESS_ERR, status=401) + return json_error_response( + DATASOURCE_ACCESS_ERR, status=401, link=config.get( + 'PERMISSION_INSTRUCTIONS_LINK')) return self.get_query_string_response(viz_obj)