From 891798b871df2def29dc16890ef9ecf4a18309a4 Mon Sep 17 00:00:00 2001 From: smileydev <47900232+prosdev0107@users.noreply.github.com> Date: Thu, 10 Mar 2022 18:15:51 -0500 Subject: [PATCH] fix(dashobard-edge-cutting): make to be not cut without Filter (#19080) (cherry picked from commit 158396fb6cce49a146d2c73b34c8eb3946163a90) --- .../DashboardBuilder/DashboardBuilder.tsx | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx index e354662c55c0..4f7ef563ce55 100644 --- a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx +++ b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx @@ -151,6 +151,7 @@ const StyledContent = styled.div<{ const StyledDashboardContent = styled.div<{ dashboardFiltersOpen: boolean; editMode: boolean; + nativeFiltersEnabled: boolean; }>` display: flex; flex-direction: row; @@ -171,8 +172,13 @@ const StyledDashboardContent = styled.div<{ margin-top: ${({ theme }) => theme.gridUnit * 6}px; margin-right: ${({ theme }) => theme.gridUnit * 8}px; margin-bottom: ${({ theme }) => theme.gridUnit * 6}px; - margin-left: ${({ theme, dashboardFiltersOpen, editMode }) => { - if (!dashboardFiltersOpen && !editMode) { + margin-left: ${({ + theme, + dashboardFiltersOpen, + editMode, + nativeFiltersEnabled, + }) => { + if (!dashboardFiltersOpen && !editMode && nativeFiltersEnabled) { return 0; } return theme.gridUnit * 8; @@ -289,9 +295,10 @@ const DashboardBuilder: FC = () => { const draggableStyle = useMemo( () => ({ - marginLeft: dashboardFiltersOpen || editMode ? 0 : -32, + marginLeft: + dashboardFiltersOpen || editMode || !nativeFiltersEnabled ? 0 : -32, }), - [dashboardFiltersOpen, editMode], + [dashboardFiltersOpen, editMode, nativeFiltersEnabled], ); const renderDraggableContent = useCallback( @@ -402,6 +409,7 @@ const DashboardBuilder: FC = () => { className="dashboard-content" dashboardFiltersOpen={dashboardFiltersOpen} editMode={editMode} + nativeFiltersEnabled={nativeFiltersEnabled} > {showDashboard ? (