From 8ef305133bcbc3dd6ba36261c5f3375a1926d93d Mon Sep 17 00:00:00 2001 From: Yongjie Zhao Date: Mon, 2 Aug 2021 23:17:45 +0800 Subject: [PATCH] code smell --- superset/utils/pandas_postprocessing.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/superset/utils/pandas_postprocessing.py b/superset/utils/pandas_postprocessing.py index 654a93a43156..0e03dea61ce2 100644 --- a/superset/utils/pandas_postprocessing.py +++ b/superset/utils/pandas_postprocessing.py @@ -271,11 +271,8 @@ def pivot( # pylint: disable=too-many-arguments series_set = set() if not drop_missing_columns and columns: for row in df[columns].itertuples(): - metrics_and_series = [] for metric in aggfunc.keys(): - metrics_and_series.append(tuple([metric]) + tuple(row[1:])) - for m_series in metrics_and_series: - series_set.add(str(m_series)) + series_set.add(str(tuple([metric]) + tuple(row[1:]))) df = df.pivot_table( values=aggfunc.keys(),