From c160a4abde0aa46beaf41a133845850f80994f32 Mon Sep 17 00:00:00 2001 From: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com> Date: Thu, 1 Jul 2021 14:25:54 -0700 Subject: [PATCH] fix(legacy-preset-chart-big-number): example images got mixed up (#1196) --- .../images/Big_Number_Trendline.jpg | Bin .../src/BigNumber/index.ts | 8 ++------ .../images/BigNumber.jpg | Bin .../images/BigNumber2.jpg | Bin .../src/BigNumberTotal/index.ts | 8 ++++++-- 5 files changed, 8 insertions(+), 8 deletions(-) rename superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/{BigNumberTotal => BigNumber}/images/Big_Number_Trendline.jpg (100%) rename superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/{BigNumber => BigNumberTotal}/images/BigNumber.jpg (100%) rename superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/{BigNumber => BigNumberTotal}/images/BigNumber2.jpg (100%) diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumberTotal/images/Big_Number_Trendline.jpg b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumber/images/Big_Number_Trendline.jpg similarity index 100% rename from superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumberTotal/images/Big_Number_Trendline.jpg rename to superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumber/images/Big_Number_Trendline.jpg diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumber/index.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumber/index.ts index b7cb2de38b39..9498015685e3 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumber/index.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumber/index.ts @@ -19,8 +19,7 @@ import { t, ChartMetadata, ChartPlugin } from '@superset-ui/core'; import controlPanel from './controlPanel'; import transformProps, { BigNumberChartProps, BigNumberFormData } from './transformProps'; -import example1 from './images/BigNumber.jpg'; -import example2 from './images/BigNumber2.jpg'; +import example from './images/Big_Number_Trendline.jpg'; import thumbnail from './images/thumbnail.png'; const metadata = new ChartMetadata({ @@ -28,10 +27,7 @@ const metadata = new ChartMetadata({ description: t( 'A single number accompanied by a simple line chart, to call attention to an important metric along with its change over time or another dimension. If you find yourself using a lot of big numbers on a dashboard, a more visual chart may help you make your dashboard more informative.', ), - exampleGallery: [ - { url: example1, caption: t('A Big Number') }, - { url: example2, caption: t('With a subheader') }, - ], + exampleGallery: [{ url: example }], name: t('Big Number with Trendline'), thumbnail, useLegacyApi: true, diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumber/images/BigNumber.jpg b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumberTotal/images/BigNumber.jpg similarity index 100% rename from superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumber/images/BigNumber.jpg rename to superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumberTotal/images/BigNumber.jpg diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumber/images/BigNumber2.jpg b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumberTotal/images/BigNumber2.jpg similarity index 100% rename from superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumber/images/BigNumber2.jpg rename to superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumberTotal/images/BigNumber2.jpg diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumberTotal/index.ts b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumberTotal/index.ts index e64d99b69e8b..0aedbc29c022 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumberTotal/index.ts +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/legacy-preset-chart-big-number/src/BigNumberTotal/index.ts @@ -22,7 +22,8 @@ import transformProps, { BigNumberChartProps, BigNumberFormData, } from '../BigNumber/transformProps'; -import example from './images/Big_Number_Trendline.jpg'; +import example1 from './images/BigNumber.jpg'; +import example2 from './images/BigNumber2.jpg'; import thumbnail from './images/thumbnail.png'; const metadata = new ChartMetadata({ @@ -30,7 +31,10 @@ const metadata = new ChartMetadata({ description: t( 'A single number that calls attention to an important metric. Good for KPI and strategic dashboards that showcase a few, focused set of metrics.', ), - exampleGallery: [{ url: example }], + exampleGallery: [ + { url: example1, caption: t('A Big Number') }, + { url: example2, caption: t('With a subheader') }, + ], name: t('Big Number'), thumbnail, useLegacyApi: true,