From c53874c8ab5457c94c6e5f00e5cbe2510bbd33db Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Fri, 20 May 2016 14:05:08 -0700 Subject: [PATCH] [hotfix] treemap was broken --- caravel/assets/visualizations/treemap.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/caravel/assets/visualizations/treemap.js b/caravel/assets/visualizations/treemap.js index 2be008f7ecfb..680d3d4f0181 100644 --- a/caravel/assets/visualizations/treemap.js +++ b/caravel/assets/visualizations/treemap.js @@ -72,13 +72,11 @@ function treemap(slice) { // We also take a snapshot of the original children (_children) to avoid // the children being overwritten when when layout is computed. var accumulate = function (d) { - var results; - if (d._children === d.children) { - results = d.children.reduce(function (p, v) { return p + accumulate(v); }, 0); - } else { - results = d.value; + d._children = d.children; + if (d._children) { + d.value = d.children.reduce(function (p, v) { return p + accumulate(v); }, 0); } - return results; + return d.value; }; // Compute the treemap layout recursively such that each group of siblings