From d0bc04fc93f0f96b603b0c4f6304cab9a802d0c1 Mon Sep 17 00:00:00 2001
From: Grace Guo <grace.guo@airbnb.com>
Date: Thu, 23 Jan 2020 17:05:39 -0800
Subject: [PATCH] [perf_logging] Add is_cached status when chart has error
 (#9009)

---
 superset/assets/src/chart/chartAction.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/superset/assets/src/chart/chartAction.js b/superset/assets/src/chart/chartAction.js
index 9859ef4c4074..38f93cb8980a 100644
--- a/superset/assets/src/chart/chartAction.js
+++ b/superset/assets/src/chart/chartAction.js
@@ -259,11 +259,12 @@ export function exploreJSON(
         return dispatch(chartUpdateSucceeded(json, key));
       })
       .catch(response => {
-        const appendErrorLog = errorDetails => {
+        const appendErrorLog = (errorDetails, isCached) => {
           dispatch(
             logEvent(LOG_ACTIONS_LOAD_CHART, {
               slice_id: key,
               has_err: true,
+              is_cached: isCached,
               error_details: errorDetails,
               datasource: formData.datasource,
               start_offset: logStart,
@@ -283,7 +284,8 @@ export function exploreJSON(
           return dispatch(chartUpdateStopped(key));
         }
         return getClientErrorObject(response).then(parsedResponse => {
-          appendErrorLog(parsedResponse.error);
+          // query is processed, but error out.
+          appendErrorLog(parsedResponse.error, parsedResponse.is_cached);
           return dispatch(chartUpdateFailed(parsedResponse, key));
         });
       });