diff --git a/superset-frontend/src/components/ErrorMessage/ErrorAlert.test.tsx b/superset-frontend/src/components/ErrorMessage/ErrorAlert.test.tsx index 7133f25c9e5e..d9fdf5efc8f7 100644 --- a/superset-frontend/src/components/ErrorMessage/ErrorAlert.test.tsx +++ b/superset-frontend/src/components/ErrorMessage/ErrorAlert.test.tsx @@ -31,6 +31,7 @@ const mockedProps = { subtitle: 'Error subtitle', title: 'Error title', source: 'dashboard' as ErrorSource, + description: 'we are unable to connect db.', }; test('should render', () => { @@ -63,6 +64,11 @@ test('should render the error title', () => { expect(screen.getByText('Error title')).toBeInTheDocument(); }); +test('should render the error description', () => { + render(, { useRedux: true }); + expect(screen.getByText('we are unable to connect db.')).toBeInTheDocument(); +}); + test('should render the error subtitle', () => { render(, { useRedux: true }); const button = screen.getByText('See more'); diff --git a/superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx b/superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx index 3340c8ad6d3e..7b8488a5b926 100644 --- a/superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx +++ b/superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx @@ -87,6 +87,7 @@ interface ErrorAlertProps { source?: ErrorSource; subtitle: ReactNode; title: ReactNode; + description?: string; } export default function ErrorAlert({ @@ -96,6 +97,7 @@ export default function ErrorAlert({ source = 'dashboard', subtitle, title, + description, }: ErrorAlertProps) { const theme = useTheme(); @@ -116,7 +118,7 @@ export default function ErrorAlert({ )} {title} - {!isExpandable && ( + {!isExpandable && !description && ( )} + {description && ( +
+

{description}

+ {!isExpandable && ( + setIsModalOpen(true)} + > + {t('See more')} + + )} +
+ )} {isExpandable ? (

{subtitle}

diff --git a/superset-frontend/src/components/ErrorMessage/ErrorMessageWithStackTrace.tsx b/superset-frontend/src/components/ErrorMessage/ErrorMessageWithStackTrace.tsx index 44bd560f39bd..b54277b4ac2d 100644 --- a/superset-frontend/src/components/ErrorMessage/ErrorMessageWithStackTrace.tsx +++ b/superset-frontend/src/components/ErrorMessage/ErrorMessageWithStackTrace.tsx @@ -32,6 +32,7 @@ type Props = { copyText?: string; stackTrace?: string; source?: ErrorSource; + description?: string; errorMitigationFunction?: () => void; }; @@ -43,6 +44,7 @@ export default function ErrorMessageWithStackTrace({ link, stackTrace, source, + description, }: Props) { // Check if a custom error message component was registered for this message if (error) { @@ -66,6 +68,7 @@ export default function ErrorMessageWithStackTrace({ title={title} subtitle={subtitle} copyText={copyText} + description={description} source={source} body={ link || stackTrace ? ( diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx index eff95313dae2..681d0a1f7961 100644 --- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx +++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx @@ -42,6 +42,7 @@ import IconButton from 'src/components/IconButton'; import InfoTooltip from 'src/components/InfoTooltip'; import withToasts from 'src/components/MessageToasts/withToasts'; import ValidatedInput from 'src/components/Form/LabeledErrorBoundInput'; +import ErrorMessageWithStackTrace from 'src/components/ErrorMessage/ErrorMessageWithStackTrace'; import ErrorAlert from 'src/components/ImportModal/ErrorAlert'; import { testDatabaseConnection, @@ -64,7 +65,6 @@ import ExtraOptions from './ExtraOptions'; import SqlAlchemyForm from './SqlAlchemyForm'; import DatabaseConnectionForm from './DatabaseConnectionForm'; import { - antDErrorAlertStyles, antDAlertStyles, antdWarningAlertStyles, StyledAlertMargin, @@ -116,6 +116,12 @@ const TabsStyled = styled(Tabs)` } `; +const ErrorAlertContainer = styled.div` + ${({ theme }) => ` + margin: ${theme.gridUnit * 8}px ${theme.gridUnit * 4}px; + `}; +`; + interface DatabaseModalProps { addDangerToast: (msg: string) => void; addSuccessToast: (msg: string) => void; @@ -475,7 +481,7 @@ const DatabaseModal: FunctionComponent = ({ )?.parameters !== undefined; const showDBError = validationErrors || dbErrors; const isEmpty = (data?: Object | null) => - data && Object.keys(data).length === 0; + !data || (data && Object.keys(data).length === 0); const dbModel: DatabaseForm = availableDbs?.databases?.find( @@ -1126,22 +1132,24 @@ const DatabaseModal: FunctionComponent = ({ // eslint-disable-next-line consistent-return const errorAlert = () => { let alertErrors: string[] = []; - if (isEmpty(dbErrors) === false) { + if (!isEmpty(dbErrors)) { alertErrors = typeof dbErrors === 'object' ? Object.values(dbErrors) : []; - } else if (db?.engine === Engines.Snowflake) { + } else if (!isEmpty(validationErrors)) { alertErrors = validationErrors?.error_type === 'GENERIC_DB_ENGINE_ERROR' - ? [validationErrors?.description] + ? [ + 'We are unable to connect to your database. Click "See more" for database-provided information that may help troubleshoot the issue.', + ] : []; } if (alertErrors.length) { return ( - antDErrorAlertStyles(theme)} - message={t('Database Creation Error')} + ); } @@ -1480,7 +1488,9 @@ const DatabaseModal: FunctionComponent = ({ onChange(ActionType.extraEditorChange, payload); }} /> - {showDBError && errorAlert()} + {showDBError && ( + {errorAlert()} + )} @@ -1641,7 +1651,9 @@ const DatabaseModal: FunctionComponent = ({ )}
{/* Step 2 */} - {showDBError && errorAlert()} + {showDBError && ( + {errorAlert()} + )} ))}