From e3dc5ee3ef6a77282cd3a79f899cad3bf078f43c Mon Sep 17 00:00:00 2001 From: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com> Date: Tue, 25 Jan 2022 15:50:45 -0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Lily Kuang --- superset-frontend/src/embedded/index.tsx | 2 +- superset/config.py | 2 +- superset/security/guest_token.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/superset-frontend/src/embedded/index.tsx b/superset-frontend/src/embedded/index.tsx index 146f4ee83e72..11a686ff2584 100644 --- a/superset-frontend/src/embedded/index.tsx +++ b/superset-frontend/src/embedded/index.tsx @@ -34,7 +34,7 @@ const LazyDashboardPage = lazy( const EmbeddedApp = () => ( - + }> diff --git a/superset/config.py b/superset/config.py index 4d00d7153f8b..5376d901a2b9 100644 --- a/superset/config.py +++ b/superset/config.py @@ -405,7 +405,7 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]: # a custom security config could potentially give access to setting filters on # tables that users do not have access to. "ROW_LEVEL_SECURITY": True, - "EMBEDDED_SUPERSET": False, # This requires that the public role be available + "EMBEDDED_SUPERSET": False, # Enables Alerts and reports new implementation "ALERT_REPORTS": False, # Enable experimental feature to search for other dashboards diff --git a/superset/security/guest_token.py b/superset/security/guest_token.py index af86da326288..44b59c1dbbb1 100644 --- a/superset/security/guest_token.py +++ b/superset/security/guest_token.py @@ -71,7 +71,7 @@ def is_authenticated(self) -> bool: def is_anonymous(self) -> bool: """ This is set to false because lots of code assumes that - role = Public if user.is_anonymous == false. + if user.is_anonymous, then role = Public But guest users need to have their own role independent of Public. """ return False