From f01d32d6d132572e227bc4fd7b2b78b576973609 Mon Sep 17 00:00:00 2001 From: Krist Wongsuphasawat Date: Sat, 9 Nov 2019 14:30:27 -0800 Subject: [PATCH] fix: lint --- .../src/vendor/cal-heatmap.js | 8 ++++---- .../src/vendor/parcoords/d3.parcoords.js | 7 ++++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-plugin-chart-calendar/src/vendor/cal-heatmap.js b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-plugin-chart-calendar/src/vendor/cal-heatmap.js index ce94c5f662a5..89f42a294d4e 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-plugin-chart-calendar/src/vendor/cal-heatmap.js +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-plugin-chart-calendar/src/vendor/cal-heatmap.js @@ -1569,8 +1569,8 @@ CalHeatMap.prototype = { element.attr('fill', function(d) { if ( d.v === null && - (options.hasOwnProperty('considerMissingDataAsZero') && - !options.considerMissingDataAsZero) + options.hasOwnProperty('considerMissingDataAsZero') && + !options.considerMissingDataAsZero ) { if (options.legendColors.hasOwnProperty('base')) { return options.legendColors.base; @@ -1616,8 +1616,8 @@ CalHeatMap.prototype = { if ( parent.legendScale === null || (d.v === null && - (options.hasOwnProperty('considerMissingDataAsZero') && - !options.considerMissingDataAsZero) && + options.hasOwnProperty('considerMissingDataAsZero') && + !options.considerMissingDataAsZero && !options.legendColors.hasOwnProperty('base')) ) { htmlClass.push('graph-rect'); diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-plugin-chart-parallel-coordinates/src/vendor/parcoords/d3.parcoords.js b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-plugin-chart-parallel-coordinates/src/vendor/parcoords/d3.parcoords.js index 61721da9ae43..741ef8e97410 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-plugin-chart-parallel-coordinates/src/vendor/parcoords/d3.parcoords.js +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-plugin-chart-parallel-coordinates/src/vendor/parcoords/d3.parcoords.js @@ -1759,9 +1759,10 @@ module.exports = function(config) { var svg = pc.selection.select('svg').select('g#arcs'), id = arc.dims.i, points = [arc.p2, arc.p3], - line = svg - .selectAll('line#arc-' + id) - .data([{ p1: arc.p1, p2: arc.p2 }, { p1: arc.p1, p2: arc.p3 }]), + line = svg.selectAll('line#arc-' + id).data([ + { p1: arc.p1, p2: arc.p2 }, + { p1: arc.p1, p2: arc.p3 }, + ]), circles = svg.selectAll('circle#arc-' + id).data(points), drag = d3.behavior.drag(), path = svg.selectAll('path#arc-' + id).data([arc]);