From 35901f83566490d5613e3544186eeaeb250fe9ce Mon Sep 17 00:00:00 2001 From: fmannhardt Date: Tue, 14 Mar 2023 19:39:01 +0100 Subject: [PATCH 1/2] Fix for variable being undefined --- .../FiltersConfigForm/FiltersConfigForm.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx index 4c18a2c85..63759f5bb 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx @@ -657,8 +657,8 @@ const FiltersConfigForm = ( const availableFilters = getAvailableFilters(filterId); const hasAvailableFilters = availableFilters.length > 0; const hasTimeDependency = availableFilters - .filter(filter => filter.type === 'filter_time') - .some(filter => dependencies.includes(filter.value)); + ?.filter(filter => filter.type === 'filter_time') + ?.some(filter => dependencies.includes(filter.value)); useEffect(() => { if (datasetId) { -- 2.39.1.windows.1 From 40ba3794066c7a141ed334fe54c6afd7f6d63ff0 Mon Sep 17 00:00:00 2001 From: fmannhardt Date: Tue, 14 Mar 2023 20:57:55 +0100 Subject: [PATCH 2/2] Fix next variable --- .../FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx index 63759f5bb..48860b70e 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx @@ -658,7 +658,7 @@ const FiltersConfigForm = ( const hasAvailableFilters = availableFilters.length > 0; const hasTimeDependency = availableFilters ?.filter(filter => filter.type === 'filter_time') - ?.some(filter => dependencies.includes(filter.value)); + ?.some(filter => dependencies?.includes(filter.value)); useEffect(() => { if (datasetId) { -- 2.39.1.windows.1