Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel.cfg omits js and ts files #17672

Closed
3 tasks done
hbruch opened this issue Dec 7, 2021 · 0 comments · Fixed by #17673
Closed
3 tasks done

babel.cfg omits js and ts files #17672

hbruch opened this issue Dec 7, 2021 · 0 comments · Fixed by #17673
Labels
#bug Bug report

Comments

@hbruch
Copy link
Contributor

hbruch commented Dec 7, 2021

With commit 3c41ff6 .js? and .ts?where introduced as glob-patterns that should match .js,.jsx,.ts, and .tsx file extensions. However, ? matches exactly one char, not one or none.

How to reproduce the bug

  1. Open https://github.com/apache/superset/blob/master/superset/translations/messages.pot and search for .js: => no message from js files is contained in the pot file

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant