feat: dataset editor improvement #10444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10444 +/- ##
===========================================
- Coverage 70.25% 59.05% -11.20%
===========================================
Files 605 409 -196
Lines 32377 13316 -19061
Branches 3271 3273 +2
===========================================
- Hits 22745 7864 -14881
+ Misses 9522 5263 -4259
- Partials 110 189 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -83,18 +83,23 @@ function ColumnCollectionTable({ | |||
| <Field | |||
| fieldKey="expression" | |||
| label={t('SQL Expression')} | |||
| control={<TextControl />} | |||
| control={ | |||
| <TextAreaControl | |||
There was a problem hiding this comment.
That looked pretty big in the <tr>, would look bad if there was many of these stacked... We may want to inline it.
There was a problem hiding this comment.
update the sql expression field to half the size
lilykuang
force-pushed
the
lily/dataset-editor-improvement
branch
from
45f8a73
to
92e4fa4
Compare
willbarrett
approved these changes
Aug 3, 2020
3 tasks
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
TEST PLAN
ADDITIONAL INFORMATION