Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up csv tests #10556

Merged
merged 5 commits into from Aug 10, 2020
Merged

chore: clean up csv tests #10556

merged 5 commits into from Aug 10, 2020

Conversation

bkyryliuk
Copy link
Member

@bkyryliuk bkyryliuk commented Aug 8, 2020 •
edited

Couple things done here:

  1. moved csv tests into a separate module
  2. made tests pytest friendly, removed unneeded dependencies
  3. moved common setup logic into the fixtures
  4. added table cleanup & moved db mutations to the newly defined database object
  5. got rid of random in the test

@bkyryliuk bkyryliuk marked this pull request as draft August 8, 2020 18:58
@bkyryliuk bkyryliuk marked this pull request as ready for review August 8, 2020 19:34
villebro
villebro approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also very nice! 👍 A few non-blocking suggestions.

tests/base_tests.py Outdated Show resolved Hide resolved
tests/base_tests.py Outdated Show resolved Hide resolved
bkyryliuk and others added 2 commits August 10, 2020 09:24
@bkyryliuk @villebro
Update tests/base_tests.py
a8580d7 
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@bkyryliuk @villebro
Update tests/base_tests.py
29038e0 
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@bkyryliuk bkyryliuk merged commit 101e5b6 into apache:master Aug 10, 2020
@bkyryliuk bkyryliuk deleted the bogdan/cvs_tests branch August 10, 2020 18:22
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
@bkyryliuk @bogdan-dbx @villebro
chore: clean up csv tests (apache#10556)
d26c107 
* Clean up csv tests

* Update tests/base_tests.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update tests/base_tests.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* import optional

* Fix mypy error

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@bkyryliuk @bogdan-dbx
@villebro @auxten
chore: clean up csv tests (apache#10556)
379f4af 
* Clean up csv tests

* Update tests/base_tests.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update tests/base_tests.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* import optional

* Fix mypy error

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbarrett willbarrett willbarrett approved these changes

@john-bodley john-bodley john-bodley approved these changes

@villebro villebro villebro approved these changes

@ktmud ktmud Awaiting requested review from ktmud

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bkyryliuk @willbarrett @john-bodley @villebro @mistercrunch @bogdan-dbx