New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Dashboard cypress refactor #11280
chore: Dashboard cypress refactor #11280
Conversation
superset-frontend/cypress-base/cypress/integration/dashboard/edit_mode.test.js
Show resolved
Hide resolved
superset-frontend/cypress-base/cypress/integration/dashboard/edit_mode.test.js
Show resolved
Hide resolved
superset-frontend/cypress-base/cypress/integration/dashboard/edit_mode.test.js
Show resolved
Hide resolved
superset-frontend/cypress-base/cypress/integration/dashboard/edit_mode.test.js
Outdated
Show resolved
Hide resolved
superset-frontend/cypress-base/cypress/integration/dashboard/tabs.test.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions on the thread, but this is looking great thus far! Obviously there are some CI issues that will need to be investigated as well, so I'll keep an eye on any relevant changes.
Codecov Report
@@ Coverage Diff @@
## master #11280 +/- ##
==========================================
- Coverage 65.69% 56.53% -9.16%
==========================================
Files 835 404 -431
Lines 39659 13410 -26249
Branches 3610 3392 -218
==========================================
- Hits 26052 7581 -18471
+ Misses 13498 5658 -7840
- Partials 109 171 +62
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/cypress-base/cypress/integration/dashboard/save.test.js
Show resolved
Hide resolved
f847e1b
to
ff8fa9d
Compare
ff8fa9d
to
1d3f47a
Compare
* moved dashboard tests to use data-test attributes * linter * fix for unstable save test
SUMMARY
I closed old PR (I thought I can reopen when ready but I forced push changes with data-test attributes from #11254 -then it was blocked by github) and resolved review suggestions from #11049.
I moved dashboard tests to use data-test attributes.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION