Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Dashboard cypress refactor #11280

Merged
merged 3 commits into from Oct 20, 2020

Conversation

adam-stasiak
Copy link
Contributor

SUMMARY

I closed old PR (I thought I can reopen when ready but I forced push changes with data-test attributes from #11254 -then it was blocked by github) and resolved review suggestions from #11049.
I moved dashboard tests to use data-test attributes.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions on the thread, but this is looking great thus far! Obviously there are some CI issues that will need to be investigated as well, so I'll keep an eye on any relevant changes.

@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #11280 into master will decrease coverage by 9.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11280      +/-   ##
==========================================
- Coverage   65.69%   56.53%   -9.16%     
==========================================
  Files         835      404     -431     
  Lines       39659    13410   -26249     
  Branches     3610     3392     -218     
==========================================
- Hits        26052     7581   -18471     
+ Misses      13498     5658    -7840     
- Partials      109      171      +62     
Flag Coverage Δ
#cypress 56.53% <ø> (+0.56%) ⬆️
#javascript ?
#python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/dashboard/components/BuilderComponentPane.jsx 100.00% <ø> (ø)
...et-frontend/src/dashboard/components/SaveModal.jsx 81.81% <ø> (ø)
...t-frontend/src/dashboard/components/SliceAdder.jsx 88.05% <ø> (-8.96%) ⬇️
...ashboard/components/gridComponents/ChartHolder.jsx 77.77% <ø> (-1.39%) ⬇️
...rontend/src/explore/components/PropertiesModal.tsx 45.76% <ø> (-13.40%) ⬇️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
...d/src/views/CRUD/csstemplates/CssTemplatesList.tsx 3.57% <0.00%> (-93.73%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
... and 664 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e4a90...1d3f47a. Read the comment docs.

@rusackas rusackas merged commit 55ae259 into apache:master Oct 20, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* moved dashboard tests to use data-test attributes

* linter

* fix for unstable save test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants