From 6f720e73ffb66e7eb7802e1dc285814beeaed2de Mon Sep 17 00:00:00 2001 From: Yongjie Zhao Date: Mon, 1 Nov 2021 19:55:42 +0800 Subject: [PATCH 1/2] fix: datatable crash when column is empty string --- .../src/explore/components/DataTableControl/index.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/superset-frontend/src/explore/components/DataTableControl/index.tsx b/superset-frontend/src/explore/components/DataTableControl/index.tsx index 10c4789c9b77..0b08f444a066 100644 --- a/superset-frontend/src/explore/components/DataTableControl/index.tsx +++ b/superset-frontend/src/explore/components/DataTableControl/index.tsx @@ -135,7 +135,8 @@ export const useTableColumns = ( key => ({ accessor: row => row[key], - Header: key, + // When the key is empty, have to give a string of length greater than 1 + Header: key || ' ', Cell: ({ value }) => { if (value === true) { return BOOL_TRUE_DISPLAY; From 49f84f4d64519755d8b863d0ee551665b644fa28 Mon Sep 17 00:00:00 2001 From: Yongjie Zhao Date: Mon, 1 Nov 2021 20:18:02 +0800 Subject: [PATCH 2/2] typo --- .../src/explore/components/DataTableControl/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset-frontend/src/explore/components/DataTableControl/index.tsx b/superset-frontend/src/explore/components/DataTableControl/index.tsx index 0b08f444a066..d36a31302092 100644 --- a/superset-frontend/src/explore/components/DataTableControl/index.tsx +++ b/superset-frontend/src/explore/components/DataTableControl/index.tsx @@ -135,7 +135,7 @@ export const useTableColumns = ( key => ({ accessor: row => row[key], - // When the key is empty, have to give a string of length greater than 1 + // When the key is empty, have to give a string of length greater than 0 Header: key || ' ', Cell: ({ value }) => { if (value === true) {