Commits on Dec 14, 2016

1. Workaround for slices "Not Found" issue in IE <= 11 …

   This should fix issue apache#1339.
   
   IE 11 and lower has a long standing issue: out-of-document element's
   pathname has no leading '/'. See
   
   https://connect.microsoft.com/IE/feedbackdetail/view/1002846/pathname-incorrect-for-out-of-document-elements
   
   And Superset's Slice.jsonEndpoint() method relies on pathname() to build
   JSON API URL for slices:
   
   ```javascript
         jsonEndpoint() {
           const parser = document.createElement('a');
           parser.href = data.json_endpoint;
           let endpoint = parser.pathname + this.querystring();
           endpoint += '&json=true';
           endpoint += '&force=' + this.force;
           return endpoint;
         },
   ```
   
   `parser` above is exactly an out-of-document element. Therefore when
   running in IE <= 11, Superset would build wrong JSON endpoint URLs,
   hence the 404 errors for loading data for slices.
   
   This commit adds a simple workaround when leading '/' is missing in the
   value returned by pathname().

   

   rlei committed Dec 14, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for 551bfff
   • Browse repository at this point

   Copy the full SHA

   551bfff View commit details

   Browse the repository at this point in the history