fix: apply url_params in global async query

[zhaoyongjie]

SUMMARY

fix Jinja template is not working when the global async query is enabled.

Currently, Superset uses serialized query_obj and form_data to generate query_cache_key. But in the global async query, we didn't pass form_data. We have to get cached data from the data cache and put the cache data to g.form_data to fix it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

url_params.before.mov

After

GAQ.after.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: fix: Jinja template is not working when async query is enabled #16650
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #18921 (c0e10f6) into master (9d5c050) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #18921   +/-   ##
=======================================
  Coverage   66.36%   66.36%           
=======================================
  Files        1621     1621           
  Lines       63057    63058    +1     
  Branches     6382     6382           
=======================================
+ Hits        41850    41851    +1     
  Misses      19547    19547           
  Partials     1660     1660           

Flag	Coverage Δ
hive	52.28% <100.00%> (+<0.01%)	⬆️
mysql	81.55% <100.00%> (+<0.01%)	⬆️
postgres	81.60% <100.00%> (+<0.01%)	⬆️
presto	52.12% <100.00%> (+<0.01%)	⬆️
python	82.04% <100.00%> (+<0.01%)	⬆️
sqlite	81.29% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/charts/data/api.py	89.87% <100.00%> (+0.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5c050...c0e10f6. Read the comment docs.

[kekwan]

@zhaoyongjie I believe global async queries have 2 code paths due to legacy charts. Does superset/explore_json/data also need to be updated in this PR?

I applied this patch to our internal fork of v1.3 and verified this fix works when requests are sent to api/v1/chart. However I still see issues when url_params are used with GAQ and the request is sent to superset/explore_json/data.

[zhaoyongjie]

Oh! Thank for pointing that out! I will check it tonight!

On Sat, Feb 26, 2022 at 08:24 Kenny Kwan ***@***.***> wrote: @zhaoyongjie <https://github.com/zhaoyongjie> I believe global async queries have 2 code paths <https://github.com/apache/superset/blob/master/superset/tasks/async_queries.py#L100>. Does superset/explore_json/data also need to be updated in this PR? I applied this patch to our internal fork of v1.3 and verified this fix works when requests are sent to api/v1/chart. However I still see issues when url_params are used with GAQ and the request is sent to superset/explore_json/data. — Reply to this email directly, view it on GitHub <#18921 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPMKUX7TN4D77BCATARLITU5AMTTANCNFSM5PHAKJ5A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Best regards, Yongjie

[zhaoyongjie]

Hi @kekwan, This issue has been fixed by PR. So I closed this one.

[SanjaySharma]

Hi, I am facing the same kind of issue. I am using the Jinja template variable {{ current_aw_user_id() }} in my queries.
my queries is very simple:

SELECT * FROM attendance where id ='{{current_aw_user_id()}}';
SELECT * FROM user where reporting_to_id ='{{current_aw_user_id()}}';

I am facing the same "Unexpected error" issue.

what could be the issue, I went through multiple posts but didn't find any solution.

[kekwan]

hey @zhaoyongjie. i don't believe this issue is fixed by #18960. I am on 1.5.1 which includes that PR but I'm still encountering this bug.

I put up #23641 which has thus fix and also patches it for legacy charts that use /explore_json endpoint as well.