Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Database import error with a new field #19037

Merged

Conversation

codemaster08240328
Copy link
Contributor

SUMMARY

Updated V1 database extra schema to make import works with allows_virtual_table_explore field.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codemaster08240328 codemaster08240328 changed the title fix Database import error with allows_virtual_table_explore field. fix Database import error with a new field. Mar 5, 2022
@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #19037 (92b8431) into master (299b5dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19037   +/-   ##
=======================================
  Coverage   66.56%   66.56%           
=======================================
  Files        1641     1641           
  Lines       63495    63498    +3     
  Branches     6425     6425           
=======================================
+ Hits        42265    42269    +4     
+ Misses      19550    19549    -1     
  Partials     1680     1680           
Flag Coverage Δ
hive 52.59% <100.00%> (-0.01%) ⬇️
mysql 81.81% <100.00%> (+<0.01%) ⬆️
postgres 81.86% <100.00%> (+<0.01%) ⬆️
presto 52.43% <100.00%> (-0.01%) ⬇️
python 82.29% <100.00%> (+<0.01%) ⬆️
sqlite 81.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/schemas.py 98.47% <100.00%> (+<0.01%) ⬆️
superset/reports/commands/execute.py 91.51% <0.00%> (ø)
superset/utils/core.py 90.25% <0.00%> (+0.02%) ⬆️
superset/common/query_context_processor.py 91.46% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299b5dc...92b8431. Read the comment docs.

@yousoph
Copy link
Member

yousoph commented Mar 6, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2022

@yousoph Ephemeral environment spinning up at http://34.216.107.117:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented Mar 6, 2022

/testenv up VERSIONED_EXPORT=True

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2022

@yousoph Ephemeral environment spinning up at http://54.68.25.19:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented Mar 7, 2022

/testenv up VERSIONED_EXPORT=True

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2022

@yousoph Ephemeral environment spinning up at http://34.208.20.84:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented Mar 7, 2022

/testenv down

@codemaster08240328 codemaster08240328 changed the title fix Database import error with a new field. fix Database import error with a new field Mar 8, 2022
@codemaster08240328 codemaster08240328 changed the title fix Database import error with a new field fix: Database import error with a new field Mar 8, 2022
@rusackas rusackas closed this Mar 8, 2022
@rusackas rusackas reopened this Mar 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

Ephemeral environment shutdown and build artifacts deleted.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

@rusackas Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

@rusackas Ephemeral environment creation failed. Please check the Actions logs for details.

@rusackas rusackas closed this Mar 8, 2022
@rusackas rusackas reopened this Mar 8, 2022
@yousoph
Copy link
Member

yousoph commented Mar 9, 2022

/testenv up FEATURE_VERSIONED_EXPORT=True

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

@yousoph Ephemeral environment spinning up at http://54.185.11.194:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented Mar 9, 2022

This is looking good to me on the ephemeral env! 🎉

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit e97cdba into apache:master Mar 10, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

villebro pushed a commit that referenced this pull request Apr 3, 2022
(cherry picked from commit e97cdba)
@mistercrunch mistercrunch added 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants