fix: Dataset search when creating a chart

[michael-s-molina]

SUMMARY

Fixes dataset search when creating a chart. Previously, when we typed "b" for example, the option "channels" was appearing in the results. That happened because the value for the dataset is in the form "table_" and since the default optionFilterProps is ['label', 'value'], the "b" was being matched with the "b" in "table". This PR fixes this by introducing an id prop and configuring optionFilterProps. Now the search is correct and we preserve the ability to search by id.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-03-08.at.10.51.37.AM.mov

Screen.Recording.2022-03-08.at.10.55.13.AM.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #19065 (8eff827) into master (2cc5678) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19065   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files        1641     1641           
  Lines       63476    63476           
  Branches     6444     6444           
=======================================
  Hits        42228    42228           
  Misses      19584    19584           
  Partials     1664     1664           

Flag	Coverage Δ
javascript	51.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...perset-frontend/src/addSlice/AddSliceContainer.tsx	61.76% <ø> (ø)
...t-frontend/src/dashboard/actions/dashboardState.js	35.95% <0.00%> (ø)
superset-frontend/src/chart/chartReducer.ts
superset-frontend/src/chart/Chart.jsx
superset-frontend/src/chart/ChartErrorMessage.tsx
superset-frontend/src/chart/ChartRenderer.jsx
superset-frontend/src/chart/ChartContainer.jsx
superset-frontend/src/chart/chartAction.js
...rontend/src/components/Chart/ChartErrorMessage.tsx	75.00% <0.00%> (ø)
...t-frontend/src/components/Chart/ChartContainer.jsx	100.00% <0.00%> (ø)
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc5678...8eff827. Read the comment docs.

[kgabryje]

LGTM