-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add duckdb as DataSource - Fixes #14563 #19317
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9129669
+ duckdb support
alitrack fd43c56
Update duckdb.py
alitrack b9c2199
Merge branch 'apache:master' into master
alitrack 9fa02d7
removed superfluous get_all_datasource_names def in duckdb engine spec
1952eaf
added exception handling for duckdb single-threaded RuntimeError
de4792e
fixed linter blips and other stylistic cleanup in duckdb.py
d1e16c4
one last round of linter tweaks in test_connection.py for duckdb support
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,77 @@ | ||||||||
# Licensed to the Apache Software Foundation (ASF) under one | ||||||||
# or more contributor license agreements. See the NOTICE file | ||||||||
# distributed with this work for additional information | ||||||||
# regarding copyright ownership. The ASF licenses this file | ||||||||
# to you under the Apache License, Version 2.0 (the | ||||||||
# "License"); you may not use this file except in compliance | ||||||||
# with the License. You may obtain a copy of the License at | ||||||||
# | ||||||||
# http://www.apache.org/licenses/LICENSE-2.0 | ||||||||
# | ||||||||
# Unless required by applicable law or agreed to in writing, | ||||||||
# software distributed under the License is distributed on an | ||||||||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||||||||
# KIND, either express or implied. See the License for the | ||||||||
# specific language governing permissions and limitations | ||||||||
# under the License. | ||||||||
import re | ||||||||
from datetime import datetime | ||||||||
from typing import Any, Dict, List, Optional, Pattern, Tuple, TYPE_CHECKING | ||||||||
|
||||||||
from flask_babel import gettext as __ | ||||||||
from sqlalchemy.engine.reflection import Inspector | ||||||||
|
||||||||
from superset.db_engine_specs.base import BaseEngineSpec | ||||||||
from superset.errors import SupersetErrorType | ||||||||
from superset.utils import core as utils | ||||||||
|
||||||||
if TYPE_CHECKING: | ||||||||
# prevent circular imports | ||||||||
from superset.models.core import Database | ||||||||
|
||||||||
|
||||||||
COLUMN_DOES_NOT_EXIST_REGEX = re.compile("no such column: (?P<column_name>.+)") | ||||||||
|
||||||||
|
||||||||
class DuckDBEngineSpec(BaseEngineSpec): | ||||||||
engine = "duckdb" | ||||||||
engine_name = "DuckDB" | ||||||||
|
||||||||
# pylint: disable=line-too-long | ||||||||
_time_grain_expressions = { | ||||||||
None: "{col}", | ||||||||
"PT1S": "DATE_TRUNC('second', {col})", | ||||||||
"PT1M": "DATE_TRUNC('minute', {col})", | ||||||||
"PT1H": "DATE_TRUNC('hour', {col})", | ||||||||
"P1D": "DATE_TRUNC('day', {col})", | ||||||||
"P1W": "DATE_TRUNC('week', {col})", | ||||||||
"P1M": "DATE_TRUNC('month', {col})", | ||||||||
"P0.25Y": "DATE_TRUNC('quarter', {col})", | ||||||||
"P1Y": "DATE_TRUNC('year', {col})", | ||||||||
} | ||||||||
|
||||||||
custom_errors: Dict[Pattern[str], Tuple[str, SupersetErrorType, Dict[str, Any]]] = { | ||||||||
COLUMN_DOES_NOT_EXIST_REGEX: ( | ||||||||
__('We can\'t seem to resolve the column "%(column_name)s"'), | ||||||||
SupersetErrorType.COLUMN_DOES_NOT_EXIST_ERROR, | ||||||||
{}, | ||||||||
), | ||||||||
} | ||||||||
|
||||||||
@classmethod | ||||||||
def epoch_to_dttm(cls) -> str: | ||||||||
return "datetime({col}, 'unixepoch')" | ||||||||
|
||||||||
@classmethod | ||||||||
def convert_dttm(cls, target_type: str, dttm: datetime) -> Optional[str]: | ||||||||
tt = target_type.upper() | ||||||||
if tt in (utils.TemporalType.TEXT, utils.TemporalType.DATETIME): | ||||||||
return f"""'{dttm.isoformat(sep=" ", timespec="microseconds")}'""" | ||||||||
return None | ||||||||
|
||||||||
@classmethod | ||||||||
def get_table_names( | ||||||||
cls, database: "Database", inspector: Inspector, schema: Optional[str] | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: if we add superset/superset/common/query_context.py Line 17 in b7ecb14
Suggested change
|
||||||||
) -> List[str]: | ||||||||
"""Need to disregard the schema for DuckDB""" | ||||||||
return sorted(inspector.get_table_names()) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could we have these in the same
except
: