From 7b3b1e43be01d29b642a9b3ba3062269c8e1133c Mon Sep 17 00:00:00 2001 From: SpiderMan Date: Tue, 19 Apr 2022 15:36:46 -0400 Subject: [PATCH 1/3] fix: chart import error with virtual dataset --- superset/charts/commands/importers/v1/__init__.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/superset/charts/commands/importers/v1/__init__.py b/superset/charts/commands/importers/v1/__init__.py index f407a4662c47..5fe70fb309c5 100644 --- a/superset/charts/commands/importers/v1/__init__.py +++ b/superset/charts/commands/importers/v1/__init__.py @@ -89,9 +89,9 @@ def _import( config.update( { "datasource_id": dataset.id, - "datasource_type": "view" - if dataset.is_sqllab_view - else "table", + "datasource_type": "table", + # if dataset.is_sqllab_view + # else "table", "datasource_name": dataset.table_name, } ) From 262f8bc2a4b27444053ce0f2eff49b89ca49330a Mon Sep 17 00:00:00 2001 From: SpiderMan Date: Tue, 19 Apr 2022 15:46:00 -0400 Subject: [PATCH 2/3] remove unnecessary comment --- superset/charts/commands/importers/v1/__init__.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/superset/charts/commands/importers/v1/__init__.py b/superset/charts/commands/importers/v1/__init__.py index 5fe70fb309c5..ab88038aaabe 100644 --- a/superset/charts/commands/importers/v1/__init__.py +++ b/superset/charts/commands/importers/v1/__init__.py @@ -90,8 +90,6 @@ def _import( { "datasource_id": dataset.id, "datasource_type": "table", - # if dataset.is_sqllab_view - # else "table", "datasource_name": dataset.table_name, } ) From 7fd8bf5f7caff6148e809d27fbf5bbe21bc1e119 Mon Sep 17 00:00:00 2001 From: SpiderMan Date: Thu, 28 Apr 2022 13:08:52 -0400 Subject: [PATCH 3/3] resolve comment --- superset/commands/importers/v1/examples.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset/commands/importers/v1/examples.py b/superset/commands/importers/v1/examples.py index 43d7e7e1fa26..679b9c441beb 100644 --- a/superset/commands/importers/v1/examples.py +++ b/superset/commands/importers/v1/examples.py @@ -138,7 +138,7 @@ def _import( # pylint: disable=arguments-differ, too-many-locals, too-many-bran dataset_info[str(dataset.uuid)] = { "datasource_id": dataset.id, - "datasource_type": "view" if dataset.is_sqllab_view else "table", + "datasource_type": "table", "datasource_name": dataset.table_name, }