feat(helm): add liveness and readiness for deployment webserver#20567
Conversation
jplanckeel
requested review from
craig-rueda,
dpgaspar and
villebro
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
craig-rueda
left a comment
craig-rueda
left a comment
There was a problem hiding this comment.
Pls bump the version in Chart.yaml
|
Still needs a version bump |
We can automate bump version, in my entreprise we automate bump version with label bump:minor, bump:major, bump;patch. is more easier and reduce error to bump version. |
|
You need to update the schema to get CI passing |
|
Hi, i updated values schema, can you merge this PR ? |
|
Hi, any update on this ? |
wiktor2200
left a comment
wiktor2200
left a comment
There was a problem hiding this comment.
There is wrong order in variable name.
|
I've got also one more question. Is not liveness/readiness probe also needed for rest Superset's elements (worker and celerybeat)? |
Co-authored-by: wiktor2200 <wiktor2200@users.noreply.github.com>
we can do this step by step, the PR is already open for several weeks. For the workers, do we have a status endpoint or a command to check the functioning? same for celery |
mistercrunch
added
🏷️ bot
…he#20567) * feat(helm): add liveness and readiness for deployment webserver * feat(helm): add example in values * feat(helm): move config probes under supersetNode * feat(helm): bump chart.yaml * fix(helm): remove default values in template and use values.yaml * fix(git): bump chart verison * fix(json): update the schema to get CI passing * fix(helm): correct path for values readiness Co-authored-by: wiktor2200 <wiktor2200@users.noreply.github.com> Co-authored-by: Jeremy PLANCKEEL <jplanckeel.externe@bedrockstreaming.com> Co-authored-by: Craig Rueda <craig@craigrueda.com> Co-authored-by: wiktor2200 <wiktor2200@users.noreply.github.com>
7 participants
SUMMARY
We want add readiness and liveness in helmchart because we need liveness to restart container automatically when server crash and readiness for to delay start.
Is best practice in K8s to have liveness and readiness. :)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION