Skip to content

feat(helm): add annotations on ServiceAccount - #21536

Merged
craig-rueda merged 1 commit into
apache:masterfrom
gforien:feat/helm/add-serviceaccount-annotations
Sep 21, 2022
Merged

feat(helm): add annotations on ServiceAccount#21536
craig-rueda merged 1 commit into
apache:masterfrom
gforien:feat/helm/add-serviceaccount-annotations

Conversation

@gforien

@gforien gforien commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

SUMMARY

We want to add annotations on the Kubernetes ServiceAccount.

How

  • Add the field in serviceaccount.yaml template
  • Add default empty value in values.yaml
  • Update JSON schema
  • Bump chart version

TESTING INSTRUCTIONS

helm lint
helm template . superset-release

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@craig-rueda
craig-rueda merged commit 8ee34e1 into apache:master Sep 21, 2022
@mistercrunch mistercrunch added the 🚢 2.1.3 First shipped in 2.1.3 label Feb 18, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 First shipped in 2.1.0 and removed 🚢 2.1.3 First shipped in 2.1.3 labels Mar 13, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Co-authored-by: gforien <gforien.externe@bedrockstreaming.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0 First shipped in 2.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants