From 96a4b241fbea0baa0cb37a46431f69b1025f48a1 Mon Sep 17 00:00:00 2001 From: Cody Leff Date: Tue, 20 Dec 2022 18:37:59 +0000 Subject: [PATCH 1/2] Hide 'Dashboards added to' column. --- .../cypress/integration/chart_list/list.test.ts | 10 +++++----- superset-frontend/src/views/CRUD/chart/ChartList.tsx | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts b/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts index c64effd41149..7f04039d19ce 100644 --- a/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts +++ b/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts @@ -114,11 +114,11 @@ describe('Charts list', () => { cy.getBySel('sort-header').eq(1).contains('Chart'); cy.getBySel('sort-header').eq(2).contains('Visualization type'); cy.getBySel('sort-header').eq(3).contains('Dataset'); - cy.getBySel('sort-header').eq(4).contains('Dashboards added to'); - cy.getBySel('sort-header').eq(5).contains('Modified by'); - cy.getBySel('sort-header').eq(6).contains('Last modified'); - cy.getBySel('sort-header').eq(7).contains('Created by'); - cy.getBySel('sort-header').eq(8).contains('Actions'); + // cy.getBySel('sort-header').eq(4).contains('Dashboards added to'); + cy.getBySel('sort-header').eq(4).contains('Modified by'); + cy.getBySel('sort-header').eq(5).contains('Last modified'); + cy.getBySel('sort-header').eq(6).contains('Created by'); + cy.getBySel('sort-header').eq(7).contains('Actions'); }); it('should sort correctly in list mode', () => { diff --git a/superset-frontend/src/views/CRUD/chart/ChartList.tsx b/superset-frontend/src/views/CRUD/chart/ChartList.tsx index d3b480479cfb..1bbaddb41191 100644 --- a/superset-frontend/src/views/CRUD/chart/ChartList.tsx +++ b/superset-frontend/src/views/CRUD/chart/ChartList.tsx @@ -401,6 +401,7 @@ function ChartList(props: ChartListProps) { accessor: 'dashboards', disableSortBy: true, size: 'xxl', + hidden: true, }, { Cell: ({ From 2dba173a036e3600136b1ef8e0b4b25301526ea2 Mon Sep 17 00:00:00 2001 From: Cody Leff Date: Tue, 20 Dec 2022 20:06:14 +0000 Subject: [PATCH 2/2] Fix tests; trigger CI. --- .../cypress-base/cypress/integration/chart_list/list.test.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts b/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts index 7f04039d19ce..29b3d16b1482 100644 --- a/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts +++ b/superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts @@ -58,7 +58,7 @@ describe('Charts list', () => { cy.preserveLogin(); }); - describe('Cross-referenced dashboards', () => { + describe.skip('Cross-referenced dashboards', () => { beforeEach(() => { cy.createSampleDashboards([0, 1, 2, 3]); cy.createSampleCharts([0]); @@ -105,6 +105,8 @@ describe('Charts list', () => { describe('list mode', () => { before(() => { + cy.createSampleDashboards([0, 1, 2, 3]); + cy.createSampleCharts([0]); visitChartList(); setGridMode('list'); });