Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filter_box] fix time filter and inverted instantFilter #2402

Merged
merged 2 commits into from Mar 14, 2017

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Mar 14, 2017

the time filter had been broken since the refactor, and the "instant filter" checkbox was inverted... Also was able to rip out some obsolete URL parsing/generation.

fixes #2372 #2356

@@ -179,15 +180,14 @@ def query_obj(self):
filters = form_data['filters'] if 'filters' in form_data \
else []
for col, vals in self.get_extra_filters().items():
if not (col and vals):
if not (col and vals) or col.startswith('__'):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add a comment about __ convention?

@bkyryliuk
Copy link
Member

LGTM

@mistercrunch mistercrunch merged commit 0b8522b into apache:master Mar 14, 2017
@mistercrunch mistercrunch deleted the fix_filtesr branch March 14, 2017 19:18
SalehHindi pushed a commit to SalehHindi/superset that referenced this pull request Jun 9, 2017
* Using the time zone with specific name for querying Druid

* Revert DRUID_TZ into tz.tzutc() (apache#2143)

[vis] render line breaks in TableViz (apache#2118)

* convert line breaks to br tags in table vis

* use css!

Keep order of axis data when storing df (apache#2092)

Implement caching and dynamic data fetching. (apache#1466)

* Rename rv => o in the decorator.

* Address comments.

* Permissions cleanup: remove none and duplicates. (apache#1967)

* Updates

* Rename var and dropdown text

* Cleanup

* Resolve comments.

* Add user to the perm check.

Add parsing for nested json objects in resultset (apache#2163)

Set default time range of query search to the past month (apache#2162)

Fix werkzeug instance was created twice in Debug Mode (apache#2135) (apache#2136)

* Fix werkzeug instance was created twice in Debug Mode (apache#2135)

* add reloader option for flask (apache#2136)

* using --no-reload option for flask

* divide a line of code into two lines for PEP8

Return original state for query if query was stopped (apache#2164)

Add command to refresh datasources (apache#2180)

use pre-wrap for long lines (apache#2181)

Adding branding assets in the repo

Moving branding assets to folder

add css to the data object to be saved (apache#2188)

[WiP] Deprecate Explore v1 (apache#2064)

* Simplifying the viz interface (apache#2005)

* Working on dashes

* Making this a collaborative branch

* Fixing some bugs

* Fixing bugs

* More improvements

* Add datasource back in bootstrap data

* Decent state

* Linting

* Moving forward

* Some more linting

* Fix the timer

* Triggering events through state

* Lingint

* Put filters in an array instead of flt strings (apache#2090)

* Put filters in an array instead of flt strings

* Remove query_filter(), put opChoices into Filter

* Update version_info.json

* Fix migrations

* More renderTrigger=true

* Fixing bugs

* Working on standalone

* getting standalone to work

* Fixed forcedHeight for standalone =view

* Linting

* Get save slice working in v2 (apache#2106)

* Filter bugfix

* Fixing empty series limit bug

* Fixed dashboard view

* Fixing short urls

* Only allow owners to overwrite slice (apache#2142)

* Raise exception when date range is wrong

* Only allow owner to overwrite a slice

* Fix tests for deprecate v1 (apache#2140)

* Fixed tests for control panels container and filters

* Fixed python tests for explorev2

* Fix linting errors

* Add in stop button during slice querying/rendering (apache#2121)

* Add in stop button during slice querying/rendering

* Abort ajax request on stop

* Adding missing legacy module

* Removing select2.sortable.js because of license

* Allow query to display while slice is loading (apache#2100)

* Allow query to display while slice is loading

* Put latestQueryFormData in store

* Reorganized query function, got rid of tu[le return values

* Merging migrations

* Wrapping up shortner migration

* Fixing tests

* Add folder creation to syncBackend

* Fixing edit URL in explore view

* Fix look of Stop button

* Adding syntax highlighting to query modal

* Fix cast_form_data and flase checkbox on dash

* Bugfix

* Going deeper

* Fix filtering

* Deleing invalid filters when changing datasource

* Minor adjustments

* Fixing calendar heatmap examples

* Moving edit datasource button to header's right side

* Fixing mapbox example

* Show stack trace when clicking alert

* Adding npm sync-backend command to build instruction

* Bumping up JS dependencies

* rm dep on select2

* Fix py3 urlparse

* rm superset-select2.js

* Improving migration scripts

* Bugfixes on staging

* Fixing Markup viz

v0.16.0

Bumping up some of the python lib deps

[hotfix] Trends example slice is broken

[hotfix] dashboard won't load, error in fields.js

[hotfix] incompatible diamond flask-sqlalchemy version

Better error handling for presto (apache#2161)

* Better error handling for presto

* Move to db_engine_spec

Bumping react-select to 1.0.0-rc.3

Fixing the build

Reverting react-select to rc2

Fixing typo

Cleaning up CLI stdout on startup

on startup, FAB spits out a bunch of logging messages that aren't useful
in most cases. This shuts them down by default. They can be turned back
on with `config.SILENCE_FAB = True`

Also shushing a flask-cache warning around setting up a null (default) cache

Fixing the CACHING (apache#2203)

Caching wasn't working after deprecate_v1, this addresses it. Also surfacing
whether the data is served from cache in explore view and a way to force
run the query bypassing the cache.

Renaming field to control (apache#2210)

v0.16.0rc1

Update cache for the command line command. (apache#2213)

  **Allow user to put dbname in url (apache#2209)

**Parse dbid from url to integer

Fixing filtering issues (apache#2223)

* Fixing filtering issues

* Fixing off by one error

0.16.0rc2

Check if the query is in state first. (apache#2226)

Fixing exploring a table (apache#2233)

0.16.0rc3

[docs] more specific about python versions

Fetch schemas separately. (apache#2227)

Add trailing slash (apache#2236)

Support more druid postaggregations. (apache#2235)

[bugfix] avoid caching errors (apache#2244)

[v0.16.1] bump version for prod release (apache#2250)

Default action to overwrite for users with overwrite permissions (apache#2257)

fix index error for bar charts (apache#2258)

v0.16.1rc1 (apache#2260)

fixes
apache#2255
apache#2252

[hotfix] separator renders markdown

Do not add slice_name when slice doesn't exist (apache#2265)

Parse filter values for possible integers and floats (apache#2263)

Introducing support for pre-depercate_v1 URL scheme (apache#2267)

[Hotfix] access slice_id when slice exists (apache#2268)

d is not defined, fix (apache#2270)

v0.16.1rc2 (apache#2272)

[hotfix] Table view doesn't allow SELECT (no group by) (apache#2274)

0.16.1rc3

[hotfix] not grouped by -2

Add Udemy to INTHEWILD (apache#2275)

[bugfix] css editor dooesn't pop up (apache#2243)

Fixing multi value parsing on old URL (apache#2277)

0.16.1rc5

Fixed a bug when querying with schema path to Redshift/Postgresql (apache#1789)

Fixing bar charts x_axis labels (apache#2280)

0.16.1rc6

added gcc-c++ for RHEL OS dependencies (apache#2286)

[hotfix] add regex for druid filters (apache#2288)

[hotfix] filters broken on multi-datasource dashboards

rc7

[table viz] allow showing time granularity in table (apache#2284)

The time granularity currently does not show up in table viz. Now
defining a granularity will add an extra ISO-formatted time column in
the table. The column will be added for both grouped by and not grouped
by.

Fixing bugs in Sankey diagrams (apache#2290)

* NULL values for name breaks the chart
* negative rect svg height values

[table viz] allow showing time granularity in table (apache#2284) (apache#2291)

The time granularity currently does not show up in table viz. Now
defining a granularity will add an extra ISO-formatted time column in
the table. The column will be added for both grouped by and not grouped
by.

Revert "[hotfix] Fix druid filters" (apache#2292)

[hotfix] Fix filter for sqlalchemy and druid (apache#2293)

* [table viz] allow showing time granularity in table (apache#2284)

The time granularity currently does not show up in table viz. Now
defining a granularity will add an extra ISO-formatted time column in
the table. The column will be added for both grouped by and not grouped
by.

* Changes based on comments

[table] Allowing to show the time grain in table view (apache#2294)

Explicitely request to show the time grain in the table view as
a checkbox

v0.17.0

v0.17.0 (apache#2298)

Temp hack to make druid filters work in dashboard (apache#2300)

Updating CHANGELOG

Fix bug with breakdown (apache#2312)

* Fix bug with breakdown

* allow distribution graph to scroll horizontally

* don't stringify i

v0.17.1 (apache#2333)

[version] use rc for production only releases (apache#2334)

[sqllab] reserved words should be upper case (apache#2316)

fix version (apache#2336)

0.17.1rc1

remove unneeded tooltip/description text (apache#2303)

Allow running Flask Blueprints alongside Superset (apache#2337)

* Allowing environments to import Blueprints

* Docs entry

* Fix typos

[hotfix] fix world map

Fix for RuntimeError: dictionary changed size during iteration (apache#2320)

[filter_box] option to delay filtering with apply button (apache#2338)

* [filter_box] delayed filtering with apply button

* Remove lingering console.log statement

Fix duplicate property DruidDatasource.database (apache#2348)

fixes apache#2347

Fixes filters emitted from table viz (apache#2335)

Add hive to superset + monkey patch the pyhive (apache#2134)

* Initial hive implementation

* Fix select star query for hive.

* Exclude generated code.

* Address code coverage and linting.

* Exclude generated code from coveralls.

* Fix lint errors

* Move TCLIService to it's own repo.

* Address comments

* Implement special postgres case,

Remove duplicate (apache#2351)

Fix partition query (apache#2353)

0.17.1rc2

Add more tests to Filter spec (apache#2315)

[table] metric ordering is wrong in some cases (apache#2373)

Refactoring Druid & SQLa into a proper "Connector" interface (apache#2362)

* Formalizing the Connector interface

* Checkpoint

* Fixing views

* Fixing tests

* Adding migrtion

* Tests

* Final

* Addressing comments

Fix monthly time grain in sqllite (apache#2380)

Keep column order in .csv (apache#2377)

Implement stop query functionality. (apache#2387)

* Implement stop query functionality.

* Address comments

Do not silence error message for query. (apache#2396)

fix unicode issues (apache#2308 apache#2282) (apache#2401)

Add more tests to Save Modal specs (apache#2313)

[filter_box] fix time filter and inverted instantFilter (apache#2402)

* [filter_box] fix time filter and inverted instantFilter

* Added a few comments

Fix bad d3.format metric setting and/or value === Infinity (apache#2399)

[explore ] templating can now reference query elements (apache#2388)

Second take on
mistercrunch#3

Preprocess the where clauses. (apache#2405)

Display full name. (apache#2378)

Revert "Preprocess the where clauses." (apache#2411)

* Revert "Display full name. (apache#2378)"

This reverts commit 5b19528.

* Revert "Preprocess the where clauses. (apache#2405)"

This reverts commit 357773c.

Use list instead of numpy array (apache#2412)

[hotfix] handle missing or empty column type

Use connector registry to fetch the table column class. (apache#2419)

Replace query once query response returned (apache#2415)

* Replace query once query response returned

* Fix bug with refresh druid datasources

Use connector registry for metrics (apache#2420)

[hotfix on dist_bar] bringing back overwritten handling of ints and tuples

v0.17.1

Allow users to alter column types (apache#2424)

Display the first partition. (apache#2425)

Add verbose name to db and druid cluster (apache#2429)

* Add verbose name field to the databases

* Add migration

* Display verbose name in the view.

make dualline thumbnail have consistent size as other thumbnails (apache#2434)

Prevent alarming users with stacktrace when using sqlite

fix a bug in pie chart (apache#2423)

* fix a bug in pie chart

* remove unnecessary line

[explore] improved filters (apache#2330)

* Support more filter operators

* more filter operators [>, <, >=, <=, ==, !=, LIKE]
* Fix need to escape/double `%` in LIKE clauses
* spinner while loading values when changing column
* datasource config elements to allow to applying predicates when
  fetching filter values
* refactor

* Removing doubling parens

* rebasing

* Merging migrations

Fix documentation for adding a Redshift database (apache#2447)

When adding a Redshift database, the docs said to use a connection
string that started with `redshift+psycopg2://...`, but this results
in a Python error from how SQLAlchemy executes the `get_schema_names`
method (first reported [here](apache#2364 (comment))).

The fix is to use `postgresql+psycog2://...` for the Redshift connection
string.

[dist_bar] fix x scroll when overflowing (apache#2440)

[hotfix] merging db migration scripts (apache#2448)

[sql-lab] make results table scroll in static container (apache#2426)

* only scroll result set horizontally

* only scroll results table, keep rest of ui static

* use hard coded values

* fix linting

[explore] remove 'SQL Clauses' section when using Druid (apache#2449)

Update INTHEWILD.md (apache#2455)

[sql-lab] improve table select performance (apache#2457)

* use fast filter for tables select

* react-virtualized needs this package, throws error otherwise...

* continue to use async select and this.getTableNamesBySubStr when a schema is not selected

* import styles in same place as react-select css import

Speeding up polling by not checking access (apache#2466)

* Speeding up polling by not checking access

* Fix tests

[WiP] making doubling '%' not required (apache#2459)

* Making doubling '%' not required

Now passing the sqlalchemy query object to pandas's read_sql_query

* Fix test/lint

[sqllab] assign types for visualize flow (apache#2458)

* [sqllab] assign types for visualize flow

Somehow when using the visualize flow, the types were not
assigned at all, creating some bugs downstream. This PR attempts to get
the information required based on what pandas is knows and the types in
the data itself.

* Fixing tests

* Fixing tests

* Fixing more tests

* Fixing the last py3 tests

[hotfix] fixing checkboxes in Tables->Columns

[hotfix] 'NoneType' object has no attribute 'upper'

Refactoring more in the connector base classes (apache#2431)

Fixed CSS syntax for background linear-gradient (apache#2482)

[hotfix] bumping QUERY_UPDATE_FREQ from 1000 to 2000ms

[sql-lab] performance updates - make ui more responsive (apache#2469)

* remove network status feature

* only fetch queries if there are started or running queries

* don't use local storage

* remove last network status from actions

* don't remove support for local storage

* address pr comments and linting

* use .some rather than .forEach

[sql-lab] revert react-virtualized-select (apache#2489)

* revert react-virtualized-select

* add space between selects

* Label is not needed

only fetch tables if we have a schema, otherwise reset options. (apache#2490)

Revert "[sql-lab] revert react-virtualized-select (apache#2489)" (apache#2491)

This reverts commit 7eafbab.

[hotfix] druid queries 'There was no query executed' issue

[release] update to 0.17.2rc1 (apache#2492)

[hotfix] SqlaTable has no attribute column_cls

v0.17.2rc2

[docs] adding notes on the Public role (apache#2486)

Stabilizing master (apache#2478)

Fixing out-of-sync security (apache#2493)

0.17.2rc3

Add ibm_db_sa TimeStamp and Datatime Grain Spec. (apache#2500)

* Add ibm_db_sa TimeStamp and Datatime Grain Spec.

* Add ibm_db_sa TimeStamp and Datatime Grain Spec. + Typo Err

Fixing filter_box css padding (apache#2498)

[explore] fixing bugs in controls (apache#2496)

Handle errors when the MQ is down (apache#2494)

0.17.2rc4

[explore] remove grey background in standalone mode (apache#2503)

* [explore] remove grey background in standalone mode

* Going with background-transparent

Adding a .pylintrc file and a bit of linting (apache#2507)

Track both query start time and button push time to track delay (apache#2502)

* Track both query start time and button push time to track delay

* Fix

* Setting the proper precision

* More logging

[hotfix] missing logging import in db_engined_specs

v0.17.2

Updating CHANGELOG

forgotten query_datasources_by_name function (apache#2497)

* forgotten query_datasources_by_name function

* use normal formats

0.17.3rc1

[hotfix]  queries trigger polling (apache#2517)

v0.17.3rc2

Adding  to polling states

v0.17.3rc3

[hotfix] fix pending queries race condition

added tobii (apache#2526)

[hotfix] fixing the (one js lint err in the) build

Redirect to explore view when saving a table (apache#2479)

Deprecate is_featured as a datasource attribute (apache#2485)

[sql lab] address lingering spinner in schema select (apache#2512)

[dashboard] allow bar charts to scroll on x axis (apache#2513)

0.17.3

WIP: Initial commit to support the athena DB (apache#2531)

* Initial commit to support the athena DB

This work was done at tobii.com (in collaboration with knowit.se), and depends on:

- A patched version of PyAthenaJDBC (https://github.com/dwa/PyAthenaJDBC/tree/dwa-tobii-dict_formatter)
- A patched version of PyHive (https://github.com/dwa/PyHive/tree/dwa-tobii-sqlalchemy-athena)

And can be used like so:
athena://<user>:<password>@athena.us-east-1.amazonaws.com/?region_name=<region>&s3_staging_dir=s3%3A//<staging_bucket_of_choice>

* Rebased, and fixed two lint issues

* rename athena engine: athena -> awsathena

installation instructions for AWS Athena (apache#2538)

druid: use six.string_types instead of basestring (apache#2541)

Which is not available in python3

Fix apache#2539

serve roboto font locally (apache#2519)

* serve roboto locally

* add trailing comma

* fix long line for linter

Some column description clarifications (apache#2536)

pylint errors will now break the build (apache#2543)

* Linting pylint errors

* Backing off of an unecessary change

[sql lab] fix table dropdown with large schema make UI unresponsive (apache#2547)

Indexing was done on render, moving to doing it only when the data
changes.

[hotfix] adding filterable to DruidColumnInlineView.edit_columns

[sql-lab] make query history scrollable (apache#2499)

* make query history scrollable

* not around results

[vis] bug num improvements (apache#2523)

* fix js error, make should render viz more readable, add tooltips, style axis and add min/max to xaxis

* put getTextWidth in utils

* add document to eslint globals config

[sql lab] allow users to save their queries (apache#2528)

* Allow users to save their queries

Fixing tests .

* Adding placeholder for Query Description

* initJQueryCSRF -> initJQueryAjaxCSRF

v0.17.4rc1

[bug num vis] fix sizing for single digits (apache#2548)

* fix sizing for single digits

* measure x axis labels too and use the longest to determine margins

Revert "measure x axis labels too and use the longest to determine margins" (apache#2550)

This reverts commit cc640c1.

Db2 Grain Correct Data Format (apache#2545)

* Db2 Grain Correct Data Format

* Db2 Grain Correct Data Format.

* Db2 Grain Correct Data Format + typo

* Db2 Grain Correct Data Format +typo

[hotfix] [sql lab] fix sqlite errors when schema is selected

Clarify docs on Redis package required for caching (apache#2557)

URL Params macro (apache#2537)

[hotfix] dashboard fails when a slice is missing its datasource

[hotfix] slice with missing datasource related

[bugfix] save dash fails with CSRF related error (apache#2552)

v0.17.4rc2

[big num] make sure scatterplot dots align properly (apache#2559)

* use cardinal so scatterplot lines up properly

* use min 30 for margins, accounts for small y axis labels

0.17.4rc3

[hotfix] iframe viz is broken

INTHEWILD: added Endress+Hauser (apache#2562)

Alternative PR for: Some bytes/str issues in py3 w/ zlib and json (apache#2558)

* sql_lab.py: compress via utils

* utils.py: added zlib_compress and zlib_compress_to_string

* core.py: converted to use zlib_decompress_to_string; renamed uncompress to decompress in utils.py

* utils_tests.py: added test for compress/decompress

* fixed broken utils test; removed redundant code and empty lines from utils.py

* utils.py: corrected docstrings, removed unnecessary 'else'

* removed yet another superfluous else

[revert] reverting big num changes (apache#2567)

* Revert "[big num] make sure scatterplot dots align properly (apache#2559)"

This reverts commit f24ddfd.

* Revert "Revert "measure x axis labels too and use the longest to determine margins" (apache#2550)"

This reverts commit fe68bc3.

* Revert "[bug num vis] fix sizing for single digits (apache#2548)"

This reverts commit 3d2c791.

* revert all big num changes.

* fix linting

* make document global, fix linting

0.17.4rc5

[bugfix] saved query restore wouldn't pick the db (apache#2568)

Fixing CSRF issues (apache#2569)

* 0.17.4

* Fixing CSRF issues

Since turning CSRF across the site with Flask-WTF, a few POST request
have been failing. This PR addresses these issues.

[hotfix] casting db_id to int

Changelog for 0.17.4

[hotfix] add csrf_token api endpoint

[hotfix] add csrf_token api endpoint

Fixing confusion when selecting schema across engines (apache#2572)

Adding Vertica to installation docs (apache#2581)

Bumping a set of Python libraries to the latest release (apache#2575)

* Bumping a set of Python libraries to the latest release

* fixing flask-sqlalchemy==2.0

Adding macros current_user_id & current_username (apache#2582)

* Adding macros current_user_id & current_username

* Addressing comments

[explore] force control validation before runQuery (apache#2544)

* [explore] force control validation before runQuery

* Addressing comments

[bugfix] clarifying how to create a slice (apache#2565)

* [bugfix] clarifying how to create a slice

First time users [rightfully] think that the proper way to create a
slice is to click the `+` button on the `Slices` CRUD page.

Changing / simplifying the redirect logic and message flashing that was
failing here somehow.

* Changing message from danger to info

Make form_data dict a macro (apache#2585)

Add missing flask-wtf dependency (apache#2586)

handle percentage case for tooltips (apache#2570)

Use correct dialect for escaping functions. (apache#2593)

Column functions are currently escaped with the
same dialect that is being used by Superset for its
metadata storage.  Instead the dialect of the target
table should be used when escaping column names.

Fix backend-sync

Fix backend-sync 2

Adding docs/ to .eslintignore

Fix metric formating in Dashboard view + some refactoring (apache#2598)

* Fix metric formating in Dashboard view + some refactoring

* Fixing build

Fix for merge string as array (apache#2597)

0.17.5.dev0

add tooltips to big number vis (apache#2599)

0.17.5-alpha.0

validationErrors is undedfined

0.17.5-alpha.1

[hotfix] fix iframe viz

0.17.5-alpha.2

Bumping the JS libs to fix the build (apache#2616)

* bumping the js libs

* New linting rules

* More linting

* More

* Done linting

* npm >=4.5.0

* Bumping node

* Tweaking the build

* Fixing the damn build

* Fixing the apps

[dashboard] fix css padding for markup viz (apache#2602)

[sql lab] fixes issues specific to Sqlite (apache#2606)

[sql lab] sorting database names in dropdowns (apache#2611)

[explore] fix query text modal while loading (apache#2596)

* [explore] fix and clean

Currently it's not possible to view queries while they are running, the
spinner appears endlessly. I decided to rearrange things a bit while
debugging so I could see clearly through it.

* Adding NotImplemented methods to base classes

* Fixing

* Piling up

[sql lab] fix alt-enter runs out-of-date SQL (apache#2603)

[hotfix] fixing the build

[hotfix] legacy url not handled properly

0.17.5-alpha.3

Fix separator widget CSS (apache#2623)

fix filters on dashboard (apache#2619)

Adding owner(s) to dashboard makes them own underlying slices (apache#2610)

[hotfix] missing explore's main.css

Add UNIX socket option to runserver (apache#2627)

* Add UNIX socket option to runserver

Added an optional parameter to runserver to server from a UNIX socket instead of an address:port. I believe it is fairly common to server from sockets when using a web server like Nginx on the same host.

* Collapsed if/else logic for address or socket

Also wrapped help description for socket parameter

Slice level cache_timeout isn't taken into consideration (apache#2631)

A nice CacheLabel React component (apache#2628)

Introducing a nice component as a label that show when data was
loaded from cache, when the cache was taken (in humanize duration as in
`a few minutes ago`) in a tooltip, and it can act as a button that
can trigger a force-refresh.

While working on it, it became clear that it was going to be hard to
use this component in the Dashboard view since it's not pure React.
I'm planning on refactoring the dashboard view with proper React/Redux
and introducing the CachedLabel component at that point.

While digging around in the Dashboard view I realized that there was a
bunch on unused code around managing timers that was used in explorev1
and decided to rip it out.

0.17.5-alpha.4

[hotfix] using UTC for caching timestamps

0.17.5-alpha.5

[hotfix] fix  endpoint

0.17.5-alpha.6

[hotfix/sqllab] setting up the connection in the try: block

Setting adjust_database_uri for HiveEngineSpec (apache#2636)

* Setting adjust_database_uri for HiveEngineSpec

* fix tests

Remove metrics control non-null validator in Table context (apache#2635)

Improving Presto error message in explore/dashboard (apache#2633)

* Improving Presto error message in explore/dashboard

* lint

Fix dashboard edit button is disabled (apache#2634)

* Fix dashboard edit button is disabled

* Addressing comments

[dashboard] improve error handling on dashboard (apache#2624)

* [dashboard] improve error handling on dashboard

* lint

* More wordy error msg

[sqllab] table refactor (apache#2587)

* make react-virtualized table work
use dynamic sizing for cell width
enable filtering
require height prop for result set component

* fix tests and linting

* move some state to props

* move getTextWidth to visUtils

* make striped rows optional

* fix striped proptype

* update name to FilterableTable

* add basic test and fix linting

* accept array of columns keys rather than an array of objects that needs to be mapped

* move container div inside the component

* rename styles

* fit table component to width if it's smaller than parent container

* move stylesheet to javascript folder otherwise it throws an error on npm run prod

* move css to index.jsx

* fix result set spec

* fix linting and test

* fix result set props

* keep list immutable

[vis] fix line chart when slice is really narrow (apache#2620)

* only show legend if larger than small breakpoint

* fix text length getter, it was returning -Infinity

0.17.5-alpha.7

Moving the warning message to the navbar (apache#2640)

At Airbnb we use these WARNING_MSG configuration element to make it
clear that we're in the staging environment.

Before this PR it would render under the navbar and mess up some of the
heights configurations, where you wouldn't be able to scroll all the way
to the bottom of the page. This fixes it.

0.17.5-alpha.8

[sql-lab] fix scrolling in left hand panel for table meta data (apache#2641)

* fix scrolling in left hand panel for table meta data

* add height prop

* this prop is not used

0.17.5-alpha.9

update core.py label and zh po file (apache#2642)

[query-search] fix scrolling on query search and pagination styling (apache#2646)

* fix scrolling for query search, getHeight was returning NAN

* add styling for query search pagination

* remove console.log

* make pagination buttons match bootstrap theme small buttons

[hotfix] Presto's latest_sub_partion rendering fail

don't default sort by to first column (apache#2653)

fix scrolling on markup vis (apache#2644)

v0.17.5-alpha.10 (apache#2654)

0.17.5

Updating CHANGELOG

superset: fix argument swap for SqliteEngineSpec.get_table_names (apache#2664)

Fix apache#2660

add the missing right bracket (apache#2662)

Optimizing the standalone view (apache#2663)

The standalone view doesn't need to fetch the datasources asynchronously
to fill in the dataources dropdown, it also doesn't need to render any
of the controls.

[druid] fix FilterBox viz gets timestamps as values if granularity <> all (apache#2647)

[druid] fixing the having clause in the explore view (apache#2648)

* [druid] fixing the having clause in the explore view

* Backend

* Lint

* Fixing tests

Fixing PropTypes warning messages (apache#2670)

* Fixing PropTypes warning message

React recently started warning on the upcoming deprecation of
React.PropTypes, the new approach is to use the `prop-types`
npm package instead.

* Fixing the tests

Showing slices on datasource edit form (apache#2645)

* Showing slices on datasource edit form

* fixing build

fix csrf error on import_dashboards (apache#2672)

add option for pulling favourited dashboards by username (apache#2661)

* add option for pulling favourited dashboards by username

add tests

* fix too many lines pep8 error

[vis] fix pivot table scrolling when using more than 1 groupy col (apache#2674)

* fix scrolling when more than 1 groupby

* generalize function arguments

* fix pivot table scrolling in js

* add padding rules back

* linting

Alternate fix for apache#2665 (apache#2671)

* Alternate fix for apache#2665

* Addressing comments

* Fix doctest

0.17.6-alpha.1

Pinning cryptography lib to 1.7.2

Specifying cryptography version in install docs

Mark a few more string for translation (apache#2651)

* Mark some more string for translations

Fix apache#2629

* Rebuild translations

* Please codeclimate

[sql lab] Update event handler name (apache#2680)

Update SqlEditor database change event handler name to be more specific.

fix a bug in 'getMaxLabelSize' and x axis label not shown problem (apache#2694)

* fix

* fix code climate

fix (apache#2692)

Fix js warnings (apache#2693)

* react: using prop-types package to fix deprecated React.PropTypes property warning

https://facebook.github.io/react/warnings/dont-call-proptypes.html

* removing babel devDependency because has been deprecated in favor of babel-cli

this fixes a warning during `npm install`:
```
npm WARN deprecated babel@6.23.0:
In 6.x, the babel package has been deprecated in favor of babel-cli.
Check https://opencollective.com/babel to support the Babel maintainers
```

* js: setting ExploreActionButtons.queryEndpoint PropType as required

because it's required in the child component DisplayQueryButton

* js(tests): using object in expandedSlices prop type of SliceCell tests

* js(tests): adding required props to SqlEditor mockedProps

* js(tests): adding required prop editorHeight to TabbedSqlEditors mockedProps

* js: removing unused moments dependency

Adding tails.com to inthewild (apache#2685)

fix x axis label (apache#2691)

hack to dynamically adjust y axis left margin (apache#2689)

* hack to dynamic adjust y axis margin

* merge into the previous hack

* render for both hack

Fix orm query in HiveEngineSpec.handle_cursor (apache#2699)

Fix apache#2643

Fix test's warnings (apache#2697)

* tests: adding required props to FilterableTable mockedProps

* tests: adding required prop `height` to QuerySearch mockedProps

* tests: adding required prop `height` to ResultSet mockedProps

* tests: adding required prop `height` to SqlEditorLeftBar mockedProps

* tests: fix warning in Timer component

[explore] fix empty chart when changing viz type (apache#2698)

* [explore] fix empty chart when changing viz type

* Lint

fix (apache#2696)

[sql lab] visualization flow: fixing the groupby parameter (apache#2681)

Fix for referring specific svg (apache#2612)

* Fix for referring specific svg

* Remove trailing space

[vis] bar values should match y axis format (apache#2701)

It passes the user yAxis format value to the totalValue function to render the label text accordingly

improve csrf expiration error handling (apache#2695)

* add message

* re run query on result set mount if there is session time out error

0.17.6-alpha.2

0.17.6

Fix missing curUserId from SliderAdder.jsx (apache#2705)

Basic integration with ClickHouse (apache#1844)

* db_engine_specs: added engine spec for clickhouse

* models: group by time without join on subquery

if this is enabled, it will remove the subquery when grouping by time,
and group by time will be rewritten as group by timeslot, ...

this particularly fixes clickhouse backend

* docs: added clickhouse

* models: allow using secondary dttm columns as constraints

* superset/forms: configurable default slice since time

* superset/models: respect dialect quoting

* dttm handling, codeclimate tweaks

Remove unecessary handling of %% (apache#2714)

[sql lab] fix csv export where `%` in query (apache#2711)

* [sql lab] fix csv export where  in query

* Prgoress

Removing uneeded results_backends.py (apache#2717)

[sql lab]Add autoSelect (apache#2713)

In sql editor database dropdown list, we want to auto-select the first available option.

[dashboard] fix missing datasource issue (apache#2718)

Addresses a bug that happens when rendering a dashboard for which
a datasource behind one of the slices has been deleted

chore: remove unused methods with invalid models.Query usage (apache#2721)

* fix: models.Query is not defined

* chore: remove unused Query and methods

[sql lab] fix CREATE TABLE AS (apache#2719)

refactor: recentActions ajax call is redundant (apache#2722)

[table] fixing CSS glitches on table view (apache#2725)

Somehow the CSS trick we use to display histogram-type visual elements
in table views started showing some odd glitches since
what I believe was a not-so-recent version of webkit.

The bug is around the `linear-gradient` call under `background-image`
prop being used to show non-gradient or "hard" colors, while using
transparency.

I was able to find a workaround that addresses things in chrome by using
a fake [minimal] gradient instead of a flat color.

0.18.0-alpha.1

Decimal is a valid numeric type (apache#2720)

* Decimal is a valid numeric type

This will allow automatic creation of sum__ and avg__ metrics

* formatting for line length at 80 chars

* Reformating again, for the mandatory 79 chars maximum.

[sql lab] improvements to the left panel (apache#2709)

* [sql lab] improvements to the left panel

* better error handling with error notifications
* table is added instantly with a loading image

* Fixing tests

* Fixed tests

[SQL Lab] fix gamma metadata access (apache#2702)

0.18.0-alpha.2

Making the stop button instantaneous (apache#2738)

0.18.0-alpha.3

fix dual line chart margin (apache#2737)

fix auto select override pre-selected value bug (apache#2745)

auto select should only apply to cases where select control doesn't have pre-selected value prop. If select control has pre-selected value (passed in from value prop), auto select first avaliable options should not apply.

Speed up all CRUD list views (apache#2747)

Load times on list view pages like Slices, Dashboards, Tables and Database
have grown to be terrible over time.

After a bit of digging, I found that the not specifying `search_columns`
in ModelViews actually means "all columns" and that for each filter,
FAB goes and fetches a list of all values to prepopulate the
filter dropdowns. That means that the list of tables would fetch all
slices and all users upfront which is horrible. Worse, database list
view would fetch all queries with is insane.

This picks a subset of columns for search/filters and changes the
default to show only 100 elements per page instead of 500

[sql lab] fix partitionned table has no partitions (apache#2740)

[sql lab] fix responsivity of grid (apache#2742)

* [sql lab] fix responsivity of grid

* Lint

0.18.0-alpha.4

make margin consistent (apache#2753)

add number format to pivot table (apache#2703)

* modify pivot table number format

* lint code

* lint code

* lint

* lint

* change variable name

* add number format to pivot table

* clean

* fix code climate

Change hardcoded references to 'User' security model to allow custom class override (apache#2728)

Fix issues around % signs and Presto (apache#2755)

* Fix issues around % signs and Presto

* Fix mysql

fix percentage change viz (apache#2757)

0.18.0

Remove duplicate text (apache#2761)

fixed 500 error when export dashboard (apache#2760)

https://github.com/airbnb/superset/blob/master/superset/views/core.py#L474

http://flask-appbuilder.readthedocs.io/en/latest/actions.html?highlight=action

```
@action("mulexport", __("Export"), __("Export dashboards?"), "fa-database")
    def mulexport(self, items):
        ids = ''.join('&id={}'.format(d.id) for d in items)
```
change to
```
@action("mulexport", __("Export"), __("Export dashboards?"), "fa-database")
    def mulexport(self, items):
        if not isinstance(items, list):
            items = [items]
        ids = ''.join('&id={}'.format(d.id) for d in items)
```

fixed:

[explore] a bit less margin in left panel (apache#2758)

* [explore] a bit less margin in left panel

* fix tests

* forcing react-select 1.0.0-rc.3

0.18.1-alpha.1

Show clear and actionable query timeout error message (apache#2763)

* Show clear and actionable query timeout error message

1. Instead of waiting for a long time or server-side response 504 Gateway timeout, explore view now add a query timeout threshold. After timeout it will show specific querytimeout message.
2. fix alert box close button position.

* Show clear and actionable query timeout error message

1. Instead of waiting for a long time or server-side response 504 Gateway timeout, explore view now add a query timeout threshold. After timeout it will show specific querytimeout message.
2. fix alert box close button position.
3. fix a linting error.

Adding `end_result_backend_time` to Query model (apache#2766)

This will help us keep track on how long it takes to push the data
into the results backend.

[hotfix] 'No numeric types to aggregate'

0.18.1-alpha.2

0.18.2

[sql lab] fix user timestamp is off (apache#2774)

[sql lab] make database ordering alphabetical in left panel (apache#2769)

Adding some STATSD logging (apache#2715)

Enable filter value autocomplete in examples (apache#2781)

[docs] more details on how filters are applied (apache#2778)

0.18.3-alpha.1

Logging a few more actions (apache#2783)

* Logging a few more actions

* adding statsd dep

Updating permission when refreshing druid datasource (apache#2655)

* Updating permission when refreshing druid datasource

* Adding test

* Fix style

* Deletion view_menu after db, table, cluster, ds deletion

* Update table model

* Linting

* Override _delete instead of post_delete

* fix

* lint

* fix multi delete

* fix

* Refactoring

* Amending

[hotfix] 'filter box from and to date filter apache#2649' (apache#2785)

Added Country Map : New Visualization tools (apache#2708)

* feat(visualization): Create new visualization's tools that display country with geojson file. Currently only  france and Spain are loaded

* refacto(visualization): fix issues created by codeclimate

* refacto(visualization): fix issues created by travis for mysql databases

* refacto(visualization): fix issues created by codeclimate

* refacto(visualization): fix issues created by codeclimate

* refacto(visualization): fix issues created by codeclimate

* refacto(visualization): fix issues created by codeclimate

* fix(visualization): fix issues

* doc(visualization): Init visualization documentation

* doc(visualization): init visualization documentation for country

* fix(visualization): implement iso 3166-2 for id of country

* fix(visualization): implement iso 3166-2 for id of country

* doc(visualization): init visualization documentation for country

* fix(visualization): implement iso 3166-2 for id of country

* feat(country_map): add ukraine map in component

* fix(visualization): Test dont working and add color based on metrics

* refacto(visualization): fix issues for es6 and color component

Fixing country maps (apache#2801)

apply redux for VisualizeModal (apache#2795)

* redux visualize modal

* redux visualize modal

- apply redux
- add unit test for connect container component
- fix lint error

* redux visualize modal

- apply redux
- add unit test for connect container component
- fix lint error

filter_box: allow creatable entries (apache#2804)

The reason is that it should be able to create arbitrary filters
over attributes with very high cardinality, where loading all
possible combinations into the filter box is infeasible,
e.g. IPv6 addresses.

[clarity/consistency] rename /explorev2/ -> /explore/ (apache#2802)

* rename /explorev2/ -> /explore/

* add redirect for existing explorev2 urls

* fix long line

* remove extra line

* fix missed ref in spec

[explore] include ControlHeader as part of Control interface (apache#2809)

* [explore] include ControlHeader as part of Control interface

* Adressing comments

reduce clientside timeout limit (apache#2820)

it was set to 60 seconds. But it seems gateway will return 504 around 50 seconds.
Will reduce client side timeout limit to 45 seconds.

0.18.3-alpha.2

Fix filter values populating for views (apache#2816)

Applying specified limit in bubble plot (apache#2815)

* Applying specified limit in bubble plot

* Keeping bubbles proportinate

[explore] viz type selector as modal (apache#2787)

* [explore] viz type selector as modal

* Addressing comments

* Adressing comments

[bars] fix sort numeric bar on x axis (apache#2812)

0.18.3-alpha.3

Improve visualize modal test coverage (apache#2811)

add unit tests for VisualizeModal component

[js-testing] more tests for SelectControl (apache#2877)

* rename spec folder

* remove special handling for viz_type control since it now uses VizTypeControl

* add test for getOptions

* linting

* add test for cwp

* linting

[explore] 'Save as' -> 'Save' as it can be used to overwrite (apache#2875)

* [explore] 'Save as' -> 'Save' as it can be used to overwrite

* Fix tests

[explore] adding y_axis_bounds to force Y axis bounds (apache#2878)

* [explore] adding y_axis_bounds to force Y axis

* Handling comments

Add visualize advise for long query (apache#2879)

in SqlLab view, if query takes over 45 seconds, we will show advise to store a summarized data set before user clicks on Visualize button.
This advise will not block Visualize button.

fixes apache#2733

Fix a type error in rst' sub list. (apache#2881)

Sub list in rst requires a blank line above and below.

Ref:
- http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#bullet-lists

[bugfix] allow database macro to work when CSRF is diabled (apache#2884)

delete DataPreviewModal, it doesn't get used anywhere (apache#2882)

Converting filter argument to number if column is number (apache#2891)

0.18.3

Updating CHANGELOG.md to 0.18.3

fix js error on explore view (apache#2894)

* fix js error on explore view

* bump version

fix a linting error (apache#2895)

0.18.4

travis: no need to install python3.5 (apache#2904)

As we are testing on 3.4 and 2.7.

update contributing a bit re contributing code (apache#2903)

* CONTRIBUTING: document starter_task label

* CONTRIBUTING: PR should work travis python versions

* CONTRIBUTING: move PR guidelines at the top

* CONTRIBUTING: no need to open a new pr after review

[docs faq] how do I add new columns to an existing table (apache#2888)

update for the italian translation (apache#2902)

* italian translation

* update for the italian translation

fix visualize modal checkbox alignment (apache#2897)

in Visualize Modal, table headers are left-aligned. So columns checkboxes should also be left-aligned.

Removed __time column from druid metadata refresh, added long and double schema support (apache#2911)

* Removed __time column from load, added long/double schema support

* Format fix

[explore] fix IN filter on numeric field (apache#2908)

[dashboard]Add timeout message on Dashboard view (apache#2910)

Same as explore view, if query takes > 45 seconds not returned, we will show Query timeout warning message. Otherwise user will see 504 Gateway timeout error.

0.18.5-alpha.1

Ignore pyenv files in .gitignore. (apache#2906)

Some python developers use Python version manager to create and switch Python
enviroments, pyenv (http://github.com/yyuu/pyenv) is one of the version managers.

When you use `pyenv local x.x.x`, `pyenv` will put a `.python-version` file in
project directory, which, in general, should not be commited to git.

updating react-alert dependency to v2.0.1 (apache#2923)

[slices] add simple new slice form (apache#2800)

* initial structure for add new slice page

* simplify add slice form

* add a test

* fix long line

* use underscore for template name

* fix controls path

* fix vis types select

add more tests for Timer (apache#2889)

[js-testing] type checking for dates.js (apache#2893)

* tests for dates.js

* linting

* test fduration output

* ignore warnings in code climate

* use eslint-2 otherwise defaults to eslint-3

* test eslint 1

* remove channel rule

* disable checks

* checks for eslint engine

[hotfix] only apply SQLAlchemy limit where needed

Observed issue in dev environment where SQL queries were emitted with
`LIMIT 0`. This fix addresses it.

v 0.18.5-alpha.2

Fix apache#2814 - json serialization edge case (apache#2924)

[big number] various improvements (apache#2912)

* [big number] various improvements

* dynamic number of X axis ticks based on width to prevent label overlap
* corrected overflow on the x axis
* improved tooltips (precise arrow and visible data point circle on hover)

* Fixing tooltips in heatmap viz

add new slice form improvements (apache#2928)

* dont set first datasource as default

* not used

* add a disabled class if datasource is not selected

* sort datasources alphabettically

* make btn disabled is no datasource is selected

* fix linting

v 0.18.5-alpha.3
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.17.1 labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.17.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[filter_box] time filters don't seem to apply in some cases
2 participants