Skip to content

fix(sql-lab): add overflow-x auto to TablePreview wrapper for horizontal scroll#39662

Open
iskanderknani2005-oss wants to merge 1 commit into
apache:masterfrom
iskanderknani2005-oss:fix/39631-sqllab-preview-horizontal-scroll
Open

fix(sql-lab): add overflow-x auto to TablePreview wrapper for horizontal scroll#39662
iskanderknani2005-oss wants to merge 1 commit into
apache:masterfrom
iskanderknani2005-oss:fix/39631-sqllab-preview-horizontal-scroll

Conversation

@iskanderknani2005-oss
Copy link
Copy Markdown

Body:
Fixes #39631

The wrapper div in TablePreview used flex: 1 1 auto but had no
overflow-x rule. Wide tables were silently clipped with no horizontal
scroll bar. Added overflow-x: auto — one line, zero logic risk.

base repository: apache/superset base: master
head repository: iskanderknani2005-oss/superset

@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented Apr 26, 2026

Code Review Agent Run #3fbffe

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 8d4d5d8..8d4d5d8
    • superset-frontend/src/SqlLab/components/TablePreview/index.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot Bot added the sqllab Namespace | Anything related to the SQL Lab label Apr 26, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 26, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 8d4d5d8
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/69ee15aae118500008031a7c
😎 Deploy Preview https://deploy-preview-39662--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hainenber
Copy link
Copy Markdown
Contributor

Thanks for opening the PR but this doesn't fix the linked issue tho. The issue is still present after applying the change on my local machine

Screen.Recording.2026-04-26.at.21.38.05.mov

@hainenber hainenber added the validation:required A committer should validate the issue label Apr 26, 2026
@sadpandajoe
Copy link
Copy Markdown
Member

@iskanderknani2005-oss is this PR still needed? I see it's trying to fix an issue that has already been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS sqllab Namespace | Anything related to the SQL Lab validation:required A committer should validate the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6.1.0rc2 No horizontal scroll bar on SqlLab Data Preview

3 participants