Skip to content

docs: Add Handlebars helper functions to README#39740

Open
Monish-1109 wants to merge 1 commit into
apache:masterfrom
Monish-1109:patch-1
Open

docs: Add Handlebars helper functions to README#39740
Monish-1109 wants to merge 1 commit into
apache:masterfrom
Monish-1109:patch-1

Conversation

@Monish-1109
Copy link
Copy Markdown

@Monish-1109 Monish-1109 commented Apr 29, 2026 •
edited
Loading

Added missing helpers to README

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Monish-1109
Add Handlebars helper functions to README
194ac4c 
Added missing helpers to README
@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented Apr 29, 2026 •
edited
Loading

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@dosubot dosubot Bot added the doc Namespace | Anything related to documentation label Apr 29, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 29, 2026

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 194ac4c
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/69f1accd6d0f340008a2de37
😎 Deploy Preview https://deploy-preview-39740--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Monish-1109
Monish-1109 commented Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Author

@Monish-1109 Monish-1109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README previously listed only a few helpers. This PR adds commonly used helpers to make documentation more accurate.

@sadpandajoe sadpandajoe requested review from Copilot and rusackas May 13, 2026 17:31
@sadpandajoe sadpandajoe changed the title Add Handlebars helper functions to README docs: Add Handlebars helper functions to README May 13, 2026
@sadpandajoe
Copy link
Copy Markdown
Member

sadpandajoe commented May 13, 2026

@Monish-1109 can you update the pull request summary on the reasoning for these changes?

@sadpandajoe sadpandajoe self-requested a review May 13, 2026 17:32
Copilot AI reviewed May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the Handlebars chart plugin README to document additional built-in helper functions.

Changes:

  • Add documentation entries for eq, neq, gt, and lt helpers.
  • Extend the “currently registered helpers” list with usage examples.

Comment thread superset-frontend/plugins/plugin-chart-handlebars/README.md
Comment on lines +97 to +107
5. **eq**: Returns true if values are equal.
- **Usage**: {{eq a b}}

6. **neq**: Returns true if values are not equal.
- **Usage**: {{neq a b}}

7. **gt**: Returns true if a > b.
- **Usage**: {{gt a b}}

8. **lt**: Returns true if a < b.
- **Usage**: {{lt a b}}
Comment thread superset-frontend/plugins/plugin-chart-handlebars/README.md

4. **`parseJson`**: Parses a JSON string into a JavaScript object.
- **Usage**: `{{parseJson jsonString}}`.

Comment thread superset-frontend/plugins/plugin-chart-handlebars/README.md
4. **`parseJson`**: Parses a JSON string into a JavaScript object.
- **Usage**: `{{parseJson jsonString}}`.

5. **eq**: Returns true if values are equal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@rusackas rusackas Awaiting requested review from rusackas

@sadpandajoe sadpandajoe Awaiting requested review from sadpandajoe

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

doc Namespace | Anything related to documentation plugins size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Monish-1109 @sadpandajoe